-
Notifications
You must be signed in to change notification settings - Fork 52
Add horizontal scrolling to IDE
component on small viewports
#897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 38d6b31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
IDE
component on small viewports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't entirely understand why, but the slight change in height of the tab is due to the overflow-x: auto
on the parent div. Toggling that in the dev tools causes a couple of pixels to be added/removed from the height of the tab.
Really not sure why it's happening...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Works great, thanks @joshfarrant
Summary
Updated the IDE component to enable horizontal scrolling on small viewports. Previously the component would cut off content on the right-hand side and not adapt to the available space, now the tabs and the editor scroll independently.
List of notable changes:
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots:
ide-responsive.mp4