feat: Add Celluloid support (with ani-skip) #1504
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Celluloid is a popular MPV frontend. Since celluloid can pass mpv arguments by using a 'mpv-' prefix in the command args, I figured it'd be easy to add. It just uses mpv on the backend after all.
I opted for not adding a new case in the switch, but instead adding the "celluloid" pattern in the mpv option. I then added an optional prefix, which is set if the player is celluloid. It could be done as a seperate option, but I wanted to prevent duplicate code.
I bumped the version to 4.10.0 as I noticed that is what you guys were aiming for in the next release. I checked 'range selection' as working, as you guys are already aware of the pre-existing bug with range selection and it's not related to this PR. The readme and help still mention that --skip only works with mpv, but since celluloid is still just mpv, I thought it was still correct.
Note: To make this work the user would have to copy ani-skip's
skip.lua
to the scripts folder under~/.config/celluloid/scripts/
instead of~/.config/mpv/scripts/
.Checklist
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work-h
help info is up to date