-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Vertx HTTP Client Metrics missing #48116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/cc @ebullient (metrics), @jmartisk (metrics) |
Can you please attach a sample I can use to debug this as it's not exactly clear to me that the issue is exactly as what is described. Thanks |
@geoand I have added a small project that you can run to see the issue. |
@ebullient for the Vert.x Client part I see the Javadoc say that |
#48145 is what we'll need, I just need to know what to use as a prefix |
@geoand is this a question for me? I am assuming you are asking @ebullient right? |
Correct |
Actually #48145 would cause |
@ebullient I wonder if we should remove Lines 80 to 82 in bd0b5e1
|
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
Vertx Http Client metrics like
http.client.queue.size
andhttp.client.queue.delay
are missing when using REST Client.I am trying to expose prometheus metrics but only
http_client_request_seconds_count
andhttp_client_request_seconds_sum
are exposed.To enable http client metrics I have set the config
Upon further investigation I notice that VertxMeterBinderAdapter:99
doesn't bind metrics if clientName is null. And there is no config that allows to set clientName.
Expected behavior
Get
http_client_queue_delay
,http_client_queue_size
andhttp_client_pending metrics
.Actual behavior
No such metrics are exposed.
How to Reproduce?
Steps for Reporducing
Timer.builder("http.client.queue.delay") is missing. As can be seen in the image below these are the only http_client metrics available.
Expected Behavior would be have access to these metrics.
Output of
uname -a
orver
No response
Output of
java -version
Java 21
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)Gradle 8.9
Additional information
No response
The text was updated successfully, but these errors were encountered: