Skip to content

HTTP protocol obtained with %H in access log doesn't conform to Common Log Format #48122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhangjiangqige opened this issue May 29, 2025 · 3 comments · Fixed by #48124
Closed

HTTP protocol obtained with %H in access log doesn't conform to Common Log Format #48122

zhangjiangqige opened this issue May 29, 2025 · 3 comments · Fixed by #48124
Labels
area/vertx kind/bug Something isn't working
Milestone
3.24 - main

Comments

@zhangjiangqige
Copy link

zhangjiangqige commented May 29, 2025 •
edited
Loading

Describe the bug

In access log when using %H to print the HTTP protocol, values like HTTP_1_1 are printed.

Expected behavior

Values like HTTP/1.1 should be printed for %H

Actual behavior

Values like HTTP_1_1 are printed.

How to Reproduce?

quarkus.http.access-log.pattern=%m %R %H would show

https://github.com/zhangjiangqige/quarkus-access-protocol-repro

Additional information

This is similar to #9940 which only addressed %r for first line of request
@zhangjiangqige zhangjiangqige added the kind/bug Something isn't working label May 29, 2025
geoand added a commit to geoand/quarkus that referenced this issue May 29, 2025
@geoand
Follow the Common Log Format in access logs for HTTP version when 'H'…
64fb28c 
… is used

Fixes: quarkusio#48122
@geoand geoand mentioned this issue May 29, 2025
Merged
@geoand
Copy link
Contributor

geoand commented May 29, 2025

#48124 fixes the issue

@geoand geoand closed this as completed in f65d988 May 29, 2025
geoand added a commit that referenced this issue May 29, 2025
@geoand
Merge pull request #48124 from geoand/#48122
073d40d 
Follow the Common Log Format in access logs for HTTP version when 'H' is used
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 29, 2025
@zhangjiangqige
Copy link
Author

Thanks @geoand ! One question, will this be backported to LTS 3.20? Can't tell by myself by looking at the labels on the pull request

@geoand
Copy link
Contributor

geoand commented May 29, 2025

Not planned currently, but we reconsider in the future (cc @gsmet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/vertx kind/bug Something isn't working
Projects
None yet
Milestone
3.24 - main
Development

Successfully merging a pull request may close this issue.

Follow the Common Log Format in access logs for HTTP version when 'H' is used geoand/quarkus
2 participants
@zhangjiangqige @geoand