Skip to content

Update SmallRye Config to 3.13.0 #47984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025
Merged

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented May 21, 2025

SmallRye Config Release notes:

3.13.0

  • #1353 Bump io.sundr:sundr-maven-plugin from 0.200.3 to 0.200.4
  • #1352 Generate dotted property from env correctly when ending with a numeric representation
  • #1349 Bump kotlin.version from 2.1.20 to 2.1.21
  • #1348 Docs: link to the config-events and config-source-injection docs
  • #1347 Generate a BOM
  • #1346 Move mapping Env matching to ConfigSource initialization
  • #1344 Bump io.smallrye.common:smallrye-common-bom from 2.10.0 to 2.12.0
  • #1342 Bump io.fabric8:docker-maven-plugin from 0.45.1 to 0.46.0
  • #1340 Bump org.ow2.asm:asm from 9.7.1 to 9.8
  • #1335 Bump kotlin.version from 2.0.21 to 2.1.20

Quarkus:

@quarkus-bot quarkus-bot bot added area/config area/dependencies Pull requests that update a dependency file area/smallrye area/kotlin labels May 21, 2025
@manofthepeace
Copy link
Contributor

I know this is not common practice to backport minor versions. But I will try again still :). It would be nice if this could go in 3.23 for ; smallrye/smallrye-config#1352

@gsmet
Copy link
Member

gsmet commented May 21, 2025

Not sure what is @radcortez's plan on this. I could be convinced to backport this one to 3.23.1 if not too risky.

I'm not sure if we need a fix for 3.20 also or if it's not affected - or not critical enough to be fixed - (it's using 3.11).

@radcortez
Copy link
Member Author

The minor version bump is because I've added a BOM module (and that was before the fix).

@manofthepeace, it is fine to update manually. Is that an option for you?

This comment has been minimized.

@manofthepeace
Copy link
Contributor

Manually updating is not an issue. I will try it, but for sure I prefer to have the quarkus-bom "ensemble".

this seems to do similar; #47964

It is fine. If you say that the version is compatible, and I can see in that PR no code change. I'll go the manual update route.

Thanks

@manofthepeace
Copy link
Contributor

Additional note;

this is what I used. It seems to work all good.

  <dependencyManagement>
    <dependencies>
      <dependency> <!-- Remove in quarkus 3.24+ -->
        <groupId>io.smallrye.config</groupId>
        <artifactId>smallrye-config-bom</artifactId>
        <version>3.13.0</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>    
      <dependency>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>${quarkus.platform.artifact-id}</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

@gsmet
Copy link
Member

gsmet commented May 22, 2025

@radcortez not sure if you have noticed that we have a test failure (stack overflow).

@radcortez
Copy link
Member Author

I'll have a look

@radcortez
Copy link
Member Author

The test failed, because the setup was somehow fragile. We are testing the recording configuration from build time and with overrides, relocates, and fallbacks.

To test it properly, we required a build time source only, which is hard to set up from a test class (possible with a separate extension). So, this used a trick to count a certain number of invocations of getPropertyNames to determine which Config instance was executing.

I rewrote the setup to use a customizer instead, which can check for the presence of a source that is only available at build time. Not perfect, but should be less fragile and wouldn't depend on the number of invocations of getPropertyNames (changed by this version of SmallRye Config).

Copy link

quarkus-bot bot commented May 22, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 164ffcf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview c179291 has been successfully built and deployed to https://quarkus-pr-main-47984-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented May 22, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 164ffcf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

  • expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-8","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-8","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)
  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gastaldi gastaldi merged commit 6d17341 into quarkusio:main May 24, 2025
59 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.24 - main milestone May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC client/filter issues after migrating from previous to latest LTS
4 participants