-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update SmallRye Config to 3.13.0 #47984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I know this is not common practice to backport minor versions. But I will try again still :). It would be nice if this could go in 3.23 for ; smallrye/smallrye-config#1352 |
Not sure what is @radcortez's plan on this. I could be convinced to backport this one to 3.23.1 if not too risky. I'm not sure if we need a fix for 3.20 also or if it's not affected - or not critical enough to be fixed - (it's using 3.11). |
The minor version bump is because I've added a BOM module (and that was before the fix). @manofthepeace, it is fine to update manually. Is that an option for you? |
This comment has been minimized.
This comment has been minimized.
Manually updating is not an issue. I will try it, but for sure I prefer to have the quarkus-bom "ensemble". this seems to do similar; #47964 It is fine. If you say that the version is compatible, and I can see in that PR no code change. I'll go the manual update route. Thanks |
Additional note; this is what I used. It seems to work all good. <dependencyManagement>
<dependencies>
<dependency> <!-- Remove in quarkus 3.24+ -->
<groupId>io.smallrye.config</groupId>
<artifactId>smallrye-config-bom</artifactId>
<version>3.13.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>${quarkus.platform.group-id}</groupId>
<artifactId>${quarkus.platform.artifact-id}</artifactId>
<version>${quarkus.platform.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement> |
@radcortez not sure if you have noticed that we have a test failure (stack overflow). |
I'll have a look |
8b43df4
to
164ffcf
Compare
The test failed, because the setup was somehow fragile. We are testing the recording configuration from build time and with overrides, relocates, and fallbacks. To test it properly, we required a build time source only, which is hard to set up from a test class (possible with a separate extension). So, this used a trick to count a certain number of invocations of I rewrote the setup to use a customizer instead, which can check for the presence of a source that is only available at build time. Not perfect, but should be less fragile and wouldn't depend on the number of invocations of |
Status for workflow
|
🎊 PR Preview c179291 has been successfully built and deployed to https://quarkus-pr-main-47984-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Quarkus: