Record access token scope in the grant response #48153
Open
+161
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48152
The main update is here - if it is authorization code flow token, check the scope from the authorization code flow response as well. This update is really relevant with social providers like GitHub when the token is binary, if it is JWT then JSON with roles/permissions is checked a few lines earlier - which is where I had to fix NPE - until now, we have only enforced
@Authenticated
at the point of login with social providers.Updated tests, confirmed I can use for example,
@PermissionsAllowed("user:email")
with the GitHub login.