compact doc #2402
Merged
compact doc #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix serde_json date Value implementation
use u32 for Addr Remove the 3 byte addressing limitation and use VInt instead
fulmicoton
reviewed
May 21, 2024
fulmicoton
reviewed
May 21, 2024
| #[derive(Clone, Copy, Default)] | ||
| #[repr(packed)] | ||
| /// The value type and the address to its payload in the container. | ||
| pub struct ValueAddr { |
There was a problem hiding this comment.
I suspect it does not have to be public?
There was a problem hiding this comment.
Yes, I'll probably add an API later for concat fields, so we can just take the ValueAddrs and add them to a Field, instead of operating on the JSON values
fulmicoton
reviewed
May 21, 2024
fulmicoton
reviewed
May 21, 2024
fulmicoton
approved these changes
May 21, 2024
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
* compact doc * add any value type * pass references when building CompactDoc * remove OwnedValue from API * clippy * clippy * fail on large documents * fmt * cleanup * cleanup * implement Value for different types fix serde_json date Value implementation * fmt * cleanup * fmt * cleanup * store positions instead of pos+len * remove nodes array * remove mediumvec * cleanup * infallible serialize into vec * remove positions indirection * remove 24MB limitation in document use u32 for Addr Remove the 3 byte addressing limitation and use VInt instead * cleanup * extend test * cleanup, add comments * rename, remove pub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces TantivyDocument with a version that is more compact, by storing all data in two vecs. (similar to tape in simd_json)
This new Document has a lower memory footprint, but has a limitation:
Fieldcan't exceedu16::MAXThis PR also fixes an issue on the
Valueimplementation onserde_json::Value, which did not handle date parsing on strings