Skip to content

refactor fast field query #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

refactor fast field query #2452

merged 1 commit into from
Jul 15, 2024

Conversation

PSeitz
Copy link
Collaborator

@PSeitz PSeitz commented Jul 12, 2024

As preparation of #2023 and #1709

  • Use Term to pass parameters
  • merge u64 and ip fast field range query

Side note: I did not rename range_query_u64_fastfield, because then git can't track the changes.

@PSeitz PSeitz force-pushed the str_fast_field_range_query2 branch 4 times, most recently from a3a40e2 to 668b7b7 Compare July 12, 2024 01:44
@PSeitz PSeitz requested a review from fulmicoton July 12, 2024 01:52
Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactoring.

As preparation of #2023 and #1709

* Use Term to pass parameters
* merge u64 and ip fast field range query

Side note: I did not rename range_query_u64_fastfield, because then git can't track the changes.
@PSeitz PSeitz force-pushed the str_fast_field_range_query2 branch from 668b7b7 to 6cca1cd Compare July 15, 2024 09:59
@PSeitz PSeitz merged commit 1b40766 into main Jul 15, 2024
4 checks passed
@PSeitz PSeitz deleted the str_fast_field_range_query2 branch July 15, 2024 10:08
philippemnoel pushed a commit to paradedb/tantivy that referenced this pull request Aug 31, 2024
As preparation of quickwit-oss#2023 and quickwit-oss#1709

* Use Term to pass parameters
* merge u64 and ip fast field range query

Side note: I did not rename range_query_u64_fastfield, because then git can't track the changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants