-
Notifications
You must be signed in to change notification settings - Fork 23
fix: fix build for next IJ version and fix Sonar coverage, bumping gradle #597
Conversation
/override ci/prow/e2e-4.11 |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -136,7 +137,6 @@ dependencies { | |||
'io.fabric8:openshift-client:6.4.1', | |||
'org.apache.commons:commons-compress:1.21', | |||
'org.apache.commons:commons-exec:1.3', | |||
'org.apache.commons:commons-lang3:3.9', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like dropping apache commons and use jetbrains platform instead. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe please explain why we need to include the kotlin plugin.
3d01b6d
to
85f7569
Compare
/override ci/prow/e2e-4.11 |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
ccbe7f0
to
15984bf
Compare
Kudos, SonarCloud Quality Gate passed! |
/override ci/prow/e2e-4.11 |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
What is the purpose of this change? What does it change?
fix next IJ build, fix sonar/jacoco coverage, bump gradle to 8.4
Was the change discussed in an issue?
fixes #591
How to test changes?