Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: fix build for next IJ version and fix Sonar coverage, bumping gradle #597

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Oct 17, 2023

What is the purpose of this change? What does it change?

fix next IJ build, fix sonar/jacoco coverage, bump gradle to 8.4

Was the change discussed in an issue?

fixes #591

How to test changes?

@sbouchet sbouchet requested a review from adietish October 17, 2023 09:54
@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-4.11

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -136,7 +137,6 @@ dependencies {
'io.fabric8:openshift-client:6.4.1',
'org.apache.commons:commons-compress:1.21',
'org.apache.commons:commons-exec:1.3',
'org.apache.commons:commons-lang3:3.9',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like dropping apache commons and use jetbrains platform instead. 👍

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe please explain why we need to include the kotlin plugin.

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 10, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet sbouchet requested a review from adietish November 10, 2023 14:04
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2023
@sbouchet sbouchet changed the title fix: fix build for next IJ version fix: fix build for next IJ version and fix Sonar coverage Nov 17, 2023
@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 17, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet sbouchet changed the title fix: fix build for next IJ version and fix Sonar coverage fix: fix build for next IJ version and fix Sonar coverage, bumping gradle Nov 17, 2023
@sbouchet
Copy link
Collaborator Author

/approve

@sbouchet sbouchet merged commit 5de882c into redhat-developer:main Nov 17, 2023
@sbouchet sbouchet deleted the fix_next_ij branch November 17, 2023 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action "Latest IJ" is failing
2 participants