This repository was archived by the owner on Apr 23, 2025. It is now read-only.
refactor: use stateful openshift client instead of ad hoc (#664) #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
changed the title
sbouchet
reviewed
Jan 19, 2024
src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java
Outdated
Show resolved
Hide resolved
sbouchet
reviewed
Jan 19, 2024
sbouchet
reviewed
Jan 19, 2024
sbouchet
reviewed
Jan 19, 2024
src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java
Outdated
Show resolved
Hide resolved
sbouchet
reviewed
Jan 19, 2024
src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java
Outdated
Show resolved
Hide resolved
adietish
force-pushed
the
issue-664
branch
2 times, most recently
from
b034610 to
accf5fe
Compare
|
/override ci/prow/e2e-openshift |
|
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
…eloper#664) Signed-off-by: Andre Dietisheim <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #664