Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

feat: list helm repositories (#672) #736

Merged
merged 1 commit into from
Mar 22, 2024
Merged

feat: list helm repositories (#672) #736

merged 1 commit into from
Mar 22, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Mar 11, 2024 •
edited
Loading

fixes #672

image

@adietish adietish self-assigned this Mar 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish force-pushed the issue-672 branch 5 times, most recently from 39f36e6 to 4e6ec65 Compare March 12, 2024 09:39
@adietish adietish requested a review from sbouchet March 12, 2024 09:42
@adietish adietish marked this pull request as ready for review March 12, 2024 09:42
@adietish adietish force-pushed the issue-672 branch 9 times, most recently from 9e10105 to ea15998 Compare March 13, 2024 11:23
@adietish adietish requested a review from sbouchet March 15, 2024 10:34
@adietish adietish force-pushed the issue-672 branch 2 times, most recently from 7a1041f to b4a8993 Compare March 19, 2024 09:21
@adietish
Copy link
Contributor Author

@sbouchet please re-review

sbouchet
sbouchet suggested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix reviews

@adietish adietish requested a review from sbouchet March 19, 2024 15:43
@adietish
Copy link
Contributor Author

@sbouchet please re-review

@sbouchet
Copy link
Collaborator

please fix conflicts

@adietish
Copy link
Contributor Author

@sbouchet please re-review

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@adietish
Copy link
Contributor Author

@sbouchet: please re-review

sbouchet
sbouchet approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 22, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 10c509b into redhat-developer:main Mar 22, 2024
@adietish adietish deleted the issue-672 branch March 25, 2024 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

@sbouchet sbouchet

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I want to see what helm repos are used on my system
3 participants
@adietish @sbouchet @openshift-merge-robot