-
Notifications
You must be signed in to change notification settings - Fork 23
fix: 'Delete Project' label is confusing when using kubernetes cluster #804
Conversation
adding also some text in the dialog to inform users about deleting all resources associated with the namespace/project (see #495) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sbouchet: IT's are failing with the details reported here: #801 (comment). I suspect ff37076 causing this. |
main branch with this commit is building fine, without IT failures. checking what's going on. |
see #805 for potential fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adietish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephane Bouchet <[email protected]>
|
/override ci/prow/e2e-openshift |
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
370056c
into
redhat-developer:main
What is the purpose of this change? What does it change?
use Project/namespace words according to current cluster kind
Was the change discussed in an issue?
fixes #708
How to test changes?