Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: 'Delete Project' label is confusing when using kubernetes cluster #804

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

sbouchet
Copy link
Collaborator

What is the purpose of this change? What does it change?

use Project/namespace words according to current cluster kind

Was the change discussed in an issue?

fixes #708

How to test changes?

@openshift-ci openshift-ci bot requested a review from adietish April 23, 2024 07:29
@sbouchet
Copy link
Collaborator Author

adding also some text in the dialog to inform users about deleting all resources associated with the namespace/project (see #495)
Capture d’écran du 2024-04-22 19-51-09

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish
Copy link
Contributor

@sbouchet: IT's are failing with the details reported here: #801 (comment). I suspect ff37076 causing this.

@sbouchet
Copy link
Collaborator Author

sbouchet commented Apr 24, 2024

@sbouchet: IT's are failing with the details reported here: #801 (comment). I suspect ff37076 causing this.

main branch with this commit is building fine, without IT failures. checking what's going on.

@sbouchet
Copy link
Collaborator Author

@adietish more like #781 , but unclear why it's failling now.

@sbouchet
Copy link
Collaborator Author

see #805 for potential fix

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 26, 2024
Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@adietish
Copy link
Contributor

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Apr 26, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 370056c into redhat-developer:main Apr 26, 2024
17 checks passed
@sbouchet sbouchet deleted the issue-708 branch April 26, 2024 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Project label is confusing when using kubernetes cluster
2 participants