Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: make sure ApplicationsRootNode is properly disposed (#868) #873

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: make sure ApplicationsRootNode is properly disposed (#868) #873

merged 1 commit into from
Jul 10, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Jul 9, 2024

fixes #868

@adietish adietish self-assigned this Jul 9, 2024
@openshift-ci openshift-ci bot requested a review from sbouchet July 9, 2024 14:51
@adietish adietish marked this pull request as draft July 9, 2024 14:53
@adietish adietish force-pushed the issue-868 branch 2 times, most recently from c4e78dd to 791f818 Compare July 9, 2024 14:59
@adietish adietish marked this pull request as ready for review July 9, 2024 14:59
@adietish adietish force-pushed the issue-868 branch 2 times, most recently from 855f3ea to 75b1b18 Compare July 9, 2024 16:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sbouchet
sbouchet approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and can't get memory leak messages anymore. good job !

@openshift-ci openshift-ci bot added the lgtm label Jul 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 10, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4e36c83 into redhat-developer:main Jul 10, 2024
17 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

@sbouchet sbouchet

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak detected: 'org.jboss.tools.intellij.openshift.tree.application.ApplicationsRootNode'
2 participants
@adietish @sbouchet