Skip to content

Removal of docker tests and related helper code #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Removal of docker tests and related helper code #4521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,6 @@ test-cmd-devfile-push:
test-cmd-devfile-exec:
ginkgo $(GINKGO_FLAGS) -focus="odo devfile exec command tests" tests/integration/devfile/

# Run odo exec docker devfile command tests
.PHONY: test-cmd-docker-devfile-exec
test-cmd-docker-devfile-exec:
ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile exec command tests" tests/integration/devfile/docker

# Run odo status devfile command tests
.PHONY: test-cmd-devfile-status
test-cmd-devfile-status:
Expand Down Expand Up @@ -311,47 +306,6 @@ test-cmd-devfile-env:
test-cmd-devfile-config:
ginkgo $(GINKGO_FLAGS) -focus="odo devfile config command tests" tests/integration/devfile/

# Fix https://github.com/openshift/odo/issues/3714 to uncomment docker make target
# # Run odo push docker devfile command tests
# .PHONY: test-cmd-docker-devfile-push
# test-cmd-docker-devfile-push:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile push command tests" tests/integration/devfile/docker/

# # Run odo watch docker devfile command tests
# .PHONY: test-cmd-docker-devfile-watch
# test-cmd-docker-devfile-watch:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile watch command tests" tests/integration/devfile/docker/

# # Run odo url docker devfile command tests
# .PHONY: test-cmd-docker-devfile-url
# test-cmd-docker-devfile-url:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile url command tests" tests/integration/devfile/docker/

# # Run odo docker devfile delete command tests
# .PHONY: test-cmd-docker-devfile-delete
# test-cmd-docker-devfile-delete:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile delete command tests" tests/integration/devfile/docker/

# Run odo status docker devfile command tests
#.PHONY: test-cmd-docker-devfile-status
#test-cmd-docker-devfile-status:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile status command tests" tests/integration/devfile/docker/

# # Run odo catalog devfile command tests
# .PHONY: test-cmd-docker-devfile-catalog
# test-cmd-docker-devfile-catalog:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile catalog command tests" tests/integration/devfile/docker/

# # Run odo url docker devfile command tests
# .PHONY: test-cmd-docker-devfile-url-pushtarget
# test-cmd-docker-devfile-url-pushtarget:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile url pushtarget command tests" tests/integration/devfile/docker/

# # Run odo test docker devfile command tests
# .PHONY: test-cmd-docker-devfile-test
# test-cmd-docker-devfile-test:
# ginkgo $(GINKGO_FLAGS) -focus="odo docker devfile test command tests" tests/integration/devfile/docker/

# Run odo watch command tests
.PHONY: test-cmd-watch
test-cmd-watch:
Expand Down
2 changes: 1 addition & 1 deletion tests/helper/helper_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package helper

import "github.com/onsi/gomega/gexec"

// CliRunner requires functions which are common for oc, kubectl and docker
// CliRunner requires functions which are common for oc and kubectl
// By abstracting these functions into an interface, it handles the cli runner and calls the functions specified to particular cluster only
type CliRunner interface {
Run(cmd string) *gexec.Session
Expand Down
270 changes: 0 additions & 270 deletions tests/helper/helper_docker.go
View file
Open in desktop

This file was deleted.

Loading