Change usecase5 to testing app name for e2e tests #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
reviewed
Jun 12, 2018
tests/e2e/e2e_test.go
Outdated
| @@ -23,6 +23,7 @@ import ( | |||
|
|
|||
| var t = strconv.FormatInt(time.Now().Unix(), 10) | |||
| var projName = fmt.Sprintf("odo-%s", t) | |||
| var appTestName = "testing" | |||
There was a problem hiding this comment.
shouldn't this be defined inside var _ = Describe("odoe2e", func() { ?
cdrage
force-pushed
the
change-from-usecase5-to-testing
branch
from
fbea73d to
6dcd899
Compare
|
@kadel I've updated the tests to indicate the new name in |
I meant something different. There is no reason to have var _ = Describe("odoe2e", func() {
appTestName := "testapp"
...
... |
Changes the ambiguous "usecase5" name to "testing". Also adds a constant to the e2e_test.go file.
cdrage
force-pushed
the
change-from-usecase5-to-testing
branch
from
6dcd899 to
cc59607
Compare
|
@kadel I see what you mean. Updated it and added the variable to be described under |
👍 Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the ambiguous "usecase5" name to "testing". Also adds a constant
to the e2e_test.go file.