Skip to content

ci: verify that codebuild jobs use ghcr.io #141643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: verify that codebuild jobs use ghcr.io #141643

wants to merge 1 commit into from
+67 −1

Conversation

marcoieni
Copy link
Member

This PR avoids that errors like #141641 happen again
r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 27, 2025
@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2025

Nice! Code looks fine, but I think that it would be better if this was a test that loads the production jobs.yml file from disk and tests it.

@marcoieni
Copy link
Member Author

done, what do you think?

@marcoieni
Copy link
Member Author

this job was failing. now it's passing because I merged with master.

@marcoieni marcoieni marked this pull request as ready for review May 27, 2025 16:05
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2025
@marcoieni
Copy link
Member Author

@rustbot ready

@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2025

Thanks, looks great!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 27, 2025

📌 Commit 783e700 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2025

@bors r-

r=me after tidy is green.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 27, 2025
@marcoieni
Copy link
Member Author

@bors r=Kobzol rollup

@bors
Copy link
Collaborator

bors commented May 28, 2025

📌 Commit bf52d1a has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 28, 2025
@jieyouxu
Rollup merge of rust-lang#141643 - marcoieni:codebuild-check, r=Kobzol
9cbfb1c 
ci: verify that codebuild jobs use ghcr.io
@jieyouxu jieyouxu mentioned this pull request May 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoieni @Kobzol @bors @rust-log-analyzer @rustbot