Make some assertions in solver into debug assertions

[compiler-errors]

These may or may not be expensive :>

r? lcnr

[compiler-errors]

@bors try @rust-timer queue

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 905fc0a with merge 4ebc75d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 4ebc75d (4ebc75d7e8da5fb25509150a501b953b7d169b4e)

[rust-timer]

Finished benchmarking commit (4ebc75d): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-1.1%, -0.2%]	10
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -5.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-5.4%, -5.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.158s -> 777.206s (-0.38%)
Artifact size: 366.33 MiB -> 366.36 MiB (0.01%)

[compiler-errors]

one percent 💀

[compiler-errors]

r? lcnr

[rustbot]

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

[lcnr]

@bors r+

[bors]

📌 Commit 905fc0a has been approved by lcnr

It is now in the queue for this repository.