Skip to content

feat: make giscus component reactive #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: comments
Choose a base branch
from

Conversation

hikaru-im
Copy link

Completed the giscus comment component, let it have the style of fuwari, and can respond to changes in light_dark_mode and hue in real time
image

Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuwari-yags ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 0:36am

@pawarherschel
Copy link
Contributor

pawarherschel commented Apr 17, 2025

I'm also adding comments and likes but via Bluesky to my blog and I just wanted to give my 2 cents.
I feel like it would be better for the comments to be below the next post and prev post buttons. That way you don't have I scroll to get to the next and prev buttons.

You can see my comments section here: https://sakurakat.systems/posts/making-the-website/#share

For the curious, it's based on https://github.com/flo-bit/blog-template

@hikaru-im
Copy link
Author

I'm also adding comments and likes but via Bluesky to my blog and I just wanted to give my 2 cents. I feel like it would be better for the comments to be below the next post and prev post buttons. That way you don't have I scroll to get to the next and prev buttons.

Thank you for your feedback! I agree that placing navigation buttons above the comments improves usability. Since this is my first PR, I kept the original code intact, but I’m open to collaborating on the changes. Your Bluesky integration idea is inspiring—would you like to submit a PR for it? We can also discuss the layout adjustments further. Looking forward to your thoughts!

@pawarherschel
Copy link
Contributor

Thank you for your feedback! I agree that placing navigation buttons above the comments improves usability. Since this is my first PR, I kept the original code intact, but I’m open to collaborating on the changes. Your Bluesky integration idea is inspiring—would you like to submit a PR for it? We can also discuss the layout adjustments further. Looking forward to your thoughts!

I'd love to submit a PR for the Bluesky integration but it's very restrictive as it requires a Bluesky account. So, I'm going to have to decline that. It also requires changes from #240 which I guess is a big change and requires approval from saicaca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants