-
Notifications
You must be signed in to change notification settings - Fork 301
Add OAuth 2.0 authentication support #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zparnold Thank you for this PR adding OAuth 2.0 authentication support! This addresses issue #238 and provides a more secure and flexible authentication option for Atlassian Cloud users.
I'm impressed with your implementation structure. You've done an excellent job separating the complex OAuth flow into a dedicated helper script and encapsulating core OAuth logic in the appropriate modules.
I have a suggestion regarding token storage that might enhance security. Currently, the implementation stores tokens in JSON files, but have you considered using the keyring library? It would store credentials in the OS's native secure storage (like macOS Keychain or Windows Credential Manager) which could provide better protection for sensitive tokens.
Thank you for your valuable feedback! I've implemented the suggested changes:
The implementation provides a secure and user-friendly way for users to authenticate with Atlassian Cloud services using OAuth 2.0. The tokens are now stored securely by default, with a fallback mechanism for environments where keyring is not available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for implementing these changes and for your great contribution!
Description
This PR adds OAuth 2.0 authentication support for Atlassian Cloud services (Jira and Confluence). This implementation allows users to authenticate using the modern OAuth 2.0 flow with Atlassian Cloud, which is more secure and flexible than API tokens, especially for integrations with third-party applications.
Fixes: #238
Changes
utils/oauth.py
scripts/oauth_authorize.py
)Testing
[Tested full OAuth flow with Atlassian Cloud, verified token refresh, and API access]
Will complete this once I have a tenant to test withChecklist