Skip to content

[puppet] add 'puppet-agent', 'openvox-agent' and 'openvox-server' to packages #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented May 28, 2025


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@pmoravec
Copy link
Contributor

It would be great if you can squash the two commits into one, but ACK either way.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4031
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@evgeni
Copy link
Contributor Author

evgeni commented May 28, 2025

done

@pmoravec pmoravec added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Quick Change This is likely a quick/trivial code change labels May 28, 2025
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would enable the plugin on puppet clients now, when the current version in main does not, correct? Or does the puppet-common package exist on clients? I don't recall off the top of my head.

I don't see anything immediately that raises concerns for me for enabling this on clients, it's just a (potentially) non-trivial change to the targets of this plugin and I want to make sure this is in fact what we want to do.

Code LGTM.

@evgeni
Copy link
Contributor Author

evgeni commented May 28, 2025

The old "puppet" and "puppet-common" names were present on clients too. At some point things got renamed to puppet-agent and puppetserver, but never completely updated here. So you could say this re-enables the plugin on clients. :)

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer labels May 28, 2025
@TurboTurtle TurboTurtle merged commit b7d12c1 into sosreport:main May 28, 2025
39 checks passed
@evgeni evgeni deleted the puppet-agent branch May 28, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Change This is likely a quick/trivial code change Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants