Add method to stream authority updates #59
+296
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
sorindumitru
force-pushed
the
get-trust-bundle
branch
4 times, most recently
from
5716ac6 to
fbfd253
Compare
Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
force-pushed
the
get-trust-bundle
branch
from
fbfd253 to
d49bef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the UpstreamAuthority protocol does not provide a way for us to listen to bundle updates without minting a new CA or publishing a new JWT key. This is problematic since it means that spire-server won't start listening for changes to upstream authorities until it first prepares a new key. If spire-server restarts and it has a key available there will be a period of time, up to the first key preparation, where it doesn't see any changes to the trust bundle of the trust domain.
Fix this by adding an optional method that can be used to only listen for trust domain updates.
part of the fix for spiffe/spire#6083