Be consistent about syntax to lock, wait, and notify #8818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dispatcher class is an outlier here as it cannot implement the Lockable interface without that leaking into its public API. We do without in that case.
swankjesse
commented
May 28, 2025
| @@ -13,6 +13,11 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| @file:Suppress( | |||
There was a problem hiding this comment.
I don’t think the compiler needed these ’cause of the friends feature, but the IDE really wanted ’em
swankjesse
commented
May 28, 2025
| @@ -212,7 +209,7 @@ class TaskQueue internal constructor( | |||
| } | |||
|
|
|||
| fun shutdown() { | |||
| lock.assertNotHeld() | |||
There was a problem hiding this comment.
This and cancelAll() were both bugs. We were asserting that a lock wasn’t held, but we never held that lock
There was a problem hiding this comment.
Sorry about this miss. If I read correctly, they would stop invalid cases that could cause corruption, rather than expose the normal path to risk of race conditions?
Thanks for catching.
yschimke
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dispatcher class is an outlier here as it cannot implement the Lockable interface without that leaking into its public API. We do without in that case.