Skip to content

Addon Vitest: Fix watch mode for new files #31156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 14, 2025

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Apr 17, 2025

Closes #31100

What I did

I have fixed watch mode for newly added story files in @storybook/addon-vitest

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-31156-sha-db97728a. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-31156-sha-db97728a
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/fix-watch-mode-for-new-files
Commit db97728a
Datetime Tue May 13 11:04:25 UTC 2025 (1747134265)
Workflow run 14994980268

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31156

Greptile Summary

This PR enhances the Vitest addon's file watching capabilities, particularly focusing on detecting and testing newly added story files by improving event handling and pattern matching.

  • Modified code/addons/vitest/src/node/vitest-manager.ts to properly handle 'add' vs 'change' events for test files
  • Replaced tinyglobby with micromatch in code/addons/vitest/src/vitest-plugin/index.ts for more reliable file pattern matching
  • Added includeStories to InternalOptions in code/addons/vitest/src/vitest-plugin/types.ts for better story inclusion control
  • Exported DEFAULT_FILES_PATTERN from code/core/src/common/utils/normalize-stories.ts for consistent file matching
  • Added environment variable support in scripts/utils/cli-step.ts for improved CLI configuration

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Apr 17, 2025

View your CI Pipeline Execution ↗ for commit 7904587.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-14 14:15:51 UTC

@yannbf yannbf changed the title WIP: Fix watch mode for new files Addon Vitest: Fix watch mode for new files Apr 17, 2025
@valentinpalkovic valentinpalkovic marked this pull request as draft April 17, 2025 22:16
valentinpalkovic and others added 4 commits April 22, 2025 14:20
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented May 13, 2025

Package Benchmarks

Commit: 7904587, ran on 14 May 2025 at 14:17:38 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-vitest

Before After Difference
Dependency count 6 6 0
Self size 616 KB 627 KB 🚨 +11 KB 🚨
Dependency size 1.49 MB 1.49 MB 0 B
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic marked this pull request as ready for review May 14, 2025 09:06
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-watch-mode-for-new-files branch from 8471d46 to 709dd90 Compare May 14, 2025 13:32
@valentinpalkovic valentinpalkovic self-assigned this May 14, 2025
@yannbf yannbf merged commit 7e7da64 into next May 14, 2025
57 checks passed
@yannbf yannbf deleted the valentin/fix-watch-mode-for-new-files branch May 14, 2025 15:13
@github-actions github-actions bot mentioned this pull request May 16, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook 9 - Storybook test does not detect newly added story file
2 participants