-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Addon Vitest: Fix watch mode for new files #31156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
View your CI Pipeline Execution ↗ for commit 7904587.
☁️ Nx Cloud last updated this comment at |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 6 | 6 | 0 |
Self size | 616 KB | 627 KB | 🚨 +11 KB 🚨 |
Dependency size | 1.49 MB | 1.49 MB | 0 B |
Bundle Size Analyzer | Link | Link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
8471d46
to
709dd90
Compare
Co-authored-by: Yann Braga <[email protected]>
Closes #31100
What I did
I have fixed watch mode for newly added story files in
@storybook/addon-vitest
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31156-sha-db97728a
. Try it out in a new sandbox by runningnpx [email protected] sandbox
or in an existing project withnpx [email protected] upgrade
.More information
0.0.0-pr-31156-sha-db97728a
valentin/fix-watch-mode-for-new-files
db97728a
1747134265
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31156
Greptile Summary
This PR enhances the Vitest addon's file watching capabilities, particularly focusing on detecting and testing newly added story files by improving event handling and pattern matching.
code/addons/vitest/src/node/vitest-manager.ts
to properly handle 'add' vs 'change' events for test filescode/addons/vitest/src/vitest-plugin/index.ts
for more reliable file pattern matchingincludeStories
to InternalOptions incode/addons/vitest/src/vitest-plugin/types.ts
for better story inclusion controlDEFAULT_FILES_PATTERN
fromcode/core/src/common/utils/normalize-stories.ts
for consistent file matchingscripts/utils/cli-step.ts
for improved CLI configuration