Skip to content

Automigration: Fix an issue when main.js addons have dynamic values #31273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Apr 28, 2025

Closes #

What I did

When the .storybook/main.js addons list contains dynamic values, the addon-essentials-remove-docs failed during its check phase.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Fixed an issue in the automigration process where dynamic values in main.js addons list caused failures during the addon-essentials-remove-docs check phase.

  • Issue appears to be focused on handling dynamic values in .storybook/main.js addon configurations
  • No specific file changes were provided in the context, so I cannot provide detailed file-specific comments
  • Based on the PR title and description, this is a targeted fix for the automigration system's handling of dynamic addon configurations

Note: Without access to the actual changed files, I've provided a minimal summary based on the PR metadata and description.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Apr 28, 2025

View your CI Pipeline Execution ↗ for commit c1e43c3.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-28 14:02:23 UTC

@valentinpalkovic valentinpalkovic merged commit c6177c7 into next Apr 28, 2025
4 of 5 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-error-when-resolving-dynamic-values-in-main-js branch April 28, 2025 13:58
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant