Skip to content

Dependencies: Update docgen #31465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Dependencies: Update docgen #31465

merged 3 commits into from
May 13, 2025

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 13, 2025

Closes: #31278

What I did

  • Updated @joshwooding/vite-plugin-react-docgen-typescript from version 0.5.0 to 0.6.0 to include improvements or fixes in the newer version.
  • Updated react-docgen from version ^7.1.1 to ^8.0.0 to align with the latest major version, which may include breaking changes or significant enhancements.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates dependencies in react-vite framework, notably upgrading react-docgen to v8 and vite-plugin-react-docgen-typescript to v0.6.0 for improved documentation generation.

  • Major version bump of react-docgen (7.x → 8.0.0) in code/frameworks/react-vite/package.json may introduce breaking changes
  • Updated @joshwooding/vite-plugin-react-docgen-typescript (0.5.0 → 0.6.0) for compatibility
  • Package now supports both Vite 5 and 6 as peer dependencies

…vite-plugin-react-docgen-typescript to 0.6.0 and react-docgen to 8.0.0; update magic-string to 0.30.0.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented May 13, 2025

View your CI Pipeline Execution ↗ for commit 8e4a794.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-13 07:42:56 UTC

@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: 8e4a794, ran on 13 May 2025 at 07:46:29 UTC

The following packages have significant changes to their size or dependencies:

@storybook/builder-webpack5

Before After Difference
Dependency count 198 198 0
Self size 80 KB 80 KB 0 B
Dependency size 31.21 MB 31.24 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/angular

Before After Difference
Dependency count 208 208 0
Self size 607 KB 607 KB 0 B
Dependency size 29.51 MB 29.54 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 208 208 0
Self size 29 KB 29 KB 0 B
Dependency size 28.77 MB 28.81 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 534 534 0
Self size 215 KB 215 KB 0 B
Dependency size 58.72 MB 58.76 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 128 127 🎉 -1 🎉
Self size 2.39 MB 2.39 MB 0 B
Dependency size 22.49 MB 22.13 MB 🎉 -368 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 161 160 🎉 -1 🎉
Self size 35 KB 35 KB 0 B
Dependency size 23.63 MB 23.26 MB 🎉 -368 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 121 120 🎉 -1 🎉
Self size 32 KB 32 KB 0 B
Dependency size 20.60 MB 20.23 MB 🎉 -368 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 284 284 0
Self size 25 KB 25 KB 0 B
Dependency size 43.51 MB 43.55 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 210 210 0
Self size 17 KB 17 KB 0 B
Dependency size 32.48 MB 32.51 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 324 324 0
Self size 243 KB 243 KB 0 B
Dependency size 97.23 MB 97.26 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 267 267 0
Self size 31 KB 31 KB 0 B
Dependency size 81.64 MB 81.67 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-react-webpack

Before After Difference
Dependency count 175 175 0
Self size 24 KB 24 KB 0 B
Dependency size 30.27 MB 30.31 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen merged commit 0fdd438 into next May 13, 2025
58 checks passed
@ndelangen ndelangen deleted the norbert/node-22-latest-compat branch May 13, 2025 08:23
@github-actions github-actions bot mentioned this pull request May 13, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React: Update vite-plugin-react-docgen-typescript
3 participants