Addon Vitest: Trigger tests on preview file changes in watch mode #31489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
approved these changes
May 15, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| VITEST_STORYBOOK: vitestStorybook, | ||
| __VITEST_INCLUDE_TAGS__: finalOptions.tags.include.join(','), | ||
| __VITEST_EXCLUDE_TAGS__: finalOptions.tags.exclude.join(','), | ||
| __VITEST_SKIP_TAGS__: finalOptions.tags.skip.join(','), | ||
| }, | ||
|
|
||
| forceRerunTriggers: [finalOptions.configDir], |
There was a problem hiding this comment.
style: forceRerunTriggers should include preview.{js,ts} specifically rather than the entire config directory to avoid unnecessary reruns
Comment on lines
+368
to
+370
| context.vitest.onFilterWatchedSpecification((spec) => { | ||
| return spec.project.config.env?.__STORYBOOK_CONFIG_DIR__ === finalOptions.configDir; | ||
| }); |
There was a problem hiding this comment.
logic: This filter could cause issues in multi-project setups where multiple Storybook instances share the same Vitest config. Consider adding additional project-specific identifiers.
|
View your CI Pipeline Execution ↗ for commit 9a1e054.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
The Vitest addon will now trigger all tests in watch mode when the preview.js file is changed, when running in the CLI!
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31489-sha-9a1e0548. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-31489-sha-9a1e0548yann/support-preview-watch-mode9a1e05481747314818)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31489Greptile Summary
Enhanced Vitest addon to trigger test reruns when preview files change in watch mode, improving development workflow for Storybook configurations.
__STORYBOOK_CONFIG_DIR__to environment variables incode/addons/vitest/src/vitest-plugin/index.tsforceRerunTriggersto include config directory for automatic test reruns