Skip to content

Next.js: Fix module transpilation #31501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 16, 2025

Closes #22070

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-31501-sha-8f7da28d. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-31501-sha-8f7da28d
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/fix-nextjs-module-transpilation
Commit 8f7da28d
Datetime Thu May 22 08:31:17 UTC 2025 (1747902677)
Workflow run 15181834915

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31501

@valentinpalkovic valentinpalkovic self-assigned this May 16, 2025
Copy link

nx-cloud bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit 8f7da28.

Command Status Duration Result
nx run-many -t check -c production --parallel=7 ✅ Succeeded 7s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-22 08:35:31 UTC

@michio-dev-my
Copy link

Hi @valentinpalkovic 👋

Thanks for this PR, I didn't know how to fix it myself.
can you please request canary release for this, I will help with testing it out.

This is very useful with libraries like nativewind, react-native-primitives etc.

@valentinpalkovic
Copy link
Contributor Author

Hi @michio-dev-my

Here you go: 0.0.0-pr-31501-sha-8f7da28d (ready in like 20 minutes)

Could you maybe provide a minimal reproduction so that I can also test it out?

@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: 8f7da28, ran on 22 May 2025 at 08:41:21 UTC

The following packages have significant changes to their size or dependencies:

@storybook/nextjs

Before After Difference
Dependency count 534 534 0
Self size 216 KB 216 KB 🚨 +508 B 🚨
Dependency size 58.69 MB 58.77 MB 🚨 +75 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 127 127 0
Self size 2.39 MB 2.39 MB 0 B
Dependency size 22.05 MB 22.13 MB 🚨 +75 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 160 160 0
Self size 35 KB 35 KB 0 B
Dependency size 23.19 MB 23.26 MB 🚨 +75 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 120 120 0
Self size 32 KB 32 KB 0 B
Dependency size 20.16 MB 20.23 MB 🚨 +75 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 284 284 0
Self size 25 KB 25 KB 0 B
Dependency size 43.48 MB 43.56 MB 🚨 +75 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react

Before After Difference
Dependency count 2 2 0
Self size 1.66 MB 1.73 MB 🚨 +75 KB 🚨
Dependency size 16 KB 16 KB 0 B
Bundle Size Analyzer Link Link

@michio-dev-my
Copy link

@valentinpalkovic thank you so much, sure sure will do the reproduction repo as well.

@TheMichio
Copy link

Hi @valentinpalkovic 👋

I'm the same guy but with my own personal github account and not with company account.

thank you so much for this update, it fixed the issue with nextjs transpilePackages issue.

you can find the repo to test it out here: https://github.com/TheMichio/nativewind-nextjs-storybook

I tried to setup the same setup in a monorepo setup, but there was some issue with jsxImportSource which I don't know is related to storybook or monorepo setup. that is a complete issue. I will check it out after releasing this.

but if you want that reproduction repo I will share it with you as well. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Next.js module transpilation is not supported
3 participants