-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Controls: Improve the accessibility of the object control #31581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sidnioulz
wants to merge
7
commits into
next
Choose a base branch
from
issue-24580
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+241
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entire document and pass it to the fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
8 tasks
View your CI Pipeline Execution ↗ for commit 5eac305.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #24150 but does not close it. The PR improves accessibility. Before the PR, it was impossible to edit JSON controls with the keyboard. Now, it's very difficult but no longer impossible.
This branch is a rebase of #24580 that has suffered significant drift. Note that I am not the original PR author and the original PR had been approved by @JReinhold. I'm opening this new PR to provide a clean CI status and to free up @fscgustavo who wrote the original PR.
I'll edit the original issue with additional steps to bring it to completion.
Caution
I recommend squashing this PR, the commit history misuses semantic commits and could lead future maintainers to think these commits aren't supposed to make user-facing changes.
Greptile Summary
Improves keyboard accessibility for JSON controls in Storybook by introducing a new accessible accordion component and enhancing keyboard navigation patterns.
JsonNodeAccordion.tsx
with proper ARIA attributes and keyboard support for JSON tree editingJsonNodes.tsx
in favor of component-level keyboard handlersObject.tsx
for better screen reader supporteditButtonElement
prop fromJsonTree
component as part of accessibility improvements