CLI: Silence automigrations and skip doctor checks in post install #31589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
maintenance
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
207
to
219
| .option('--silent', 'Silent mode') | ||
| .option('--skip-doctor', 'Skip doctor check') |
There was a problem hiding this comment.
style: consider adding descriptions for these options to match style of other options
|
View your CI Pipeline Execution ↗ for commit 17d7065.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 6 | 6 | 0 |
| Self size | 629 KB | 552 KB | 🎉 -77 KB 🎉 |
| Dependency size | 1.49 MB | 1.49 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
yannbf
force-pushed
the
yann/silence-postinstall-steps
branch
from
7170776 to
3c1c790
Compare
yannbf
commented
May 28, 2025
yannbf
force-pushed
the
yann/silence-postinstall-steps
branch
from
614882f to
d3eb4c7
Compare
yannbf
force-pushed
the
yann/silence-postinstall-steps
branch
from
d3eb4c7 to
308ce03
Compare
yannbf
merged commit aecf389
into
valentin/monorepo-enhancements
53 of 55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31589-sha-71707764. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-31589-sha-71707764yann/silence-postinstall-steps717077641748425865)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31589Greptile Summary
This PR adds options to silence automigrations and skip doctor checks during post-installation across Storybook's CLI and addons, streamlining the installation process by reducing verbose output and optional checks.
silentandskipDoctoroptions toAutofixOptionsFromCLIinterface incode/lib/cli-storybook/src/automigrate/types.tscode/lib/cli-storybook/src/bin/index.tsto support new--silentand--skip-doctorCLI flagscode/addons/a11y/src/postinstall.tsandcode/addons/vitest/src/postinstall.tsto use new silent flagscode/lib/cli-storybook/src/automigrate/index.tsto respect silent mode