Skip to content

[LiPS] Add bank account feature flag + base menu #10762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

[LiPS] Add bank account feature flag + base menu #10762

wants to merge 15 commits into from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │   4.3 MiB │   4.3 MiB │  +6.9 KiB │   9.5 MiB │   9.5 MiB │   +15 KiB 
     arsc │   2.5 MiB │   2.5 MiB │  +1.4 KiB │   2.5 MiB │   2.5 MiB │  +1.4 KiB 
 manifest │   5.6 KiB │   5.6 KiB │      -9 B │  28.7 KiB │  28.7 KiB │     -40 B 
      res │ 911.4 KiB │   912 KiB │    +624 B │   1.4 MiB │   1.4 MiB │  +1.1 KiB 
   native │   3.5 MiB │   3.5 MiB │       0 B │   8.5 MiB │   8.5 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │  +1.5 KiB │   1.6 MiB │   1.6 MiB │  +1.5 KiB 
    other │ 197.1 KiB │ 197.2 KiB │    +120 B │ 372.2 KiB │ 372.4 KiB │    +164 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │    13 MiB │    13 MiB │ +10.5 KiB │  23.9 MiB │  23.9 MiB │ +19.1 KiB 

         │         raw          │              unique               
         ├───────┬───────┬──────┼───────┬───────┬───────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff              
─────────┼───────┼───────┼──────┼───────┼───────┼───────────────────
   files │     2 │     2 │    0 │       │       │                   
 strings │ 46118 │ 46185 │  +67 │ 45477 │ 45527 │ +50 (+109 -59)    
   types │ 16229 │ 16255 │  +26 │ 15955 │ 15971 │ +16 (+66 -50)     
 classes │ 13473 │ 13488 │  +15 │ 13473 │ 13488 │ +15 (+28 -13)     
 methods │ 66251 │ 66312 │  +61 │ 65903 │ 65953 │ +50 (+2925 -2875) 
  fields │ 43863 │ 43963 │ +100 │ 43729 │ 43816 │ +87 (+2378 -2291) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  242 │  0         
 entries │ 6308 │ 6310 │ +2 (+4 -2)
APK 
      compressed      │     uncompressed      │                                           
──────────┬───────────┼───────────┬───────────┤                                           
 size     │ diff      │ size      │ diff      │ path                                      
──────────┼───────────┼───────────┼───────────┼───────────────────────────────────────────
  4.3 MiB │  +4.6 KiB │   9.4 MiB │    +9 KiB │ ∆ classes.dex                             
 38.1 KiB │  +2.3 KiB │    86 KiB │  +6.1 KiB │ ∆ classes2.dex                            
  8.3 KiB │  +1.5 KiB │   8.1 KiB │  +1.5 KiB │ ∆ assets/dexopt/baseline.prof             
  2.5 MiB │  +1.4 KiB │   2.5 MiB │  +1.4 KiB │ ∆ resources.arsc                          
    740 B │    +740 B │   1.2 KiB │  +1.2 KiB │ + res/Vp.xml                              
          │    -740 B │           │  -1.2 KiB │ - res/TG.xml                              
    626 B │    +626 B │   1.1 KiB │  +1.1 KiB │ + res/jF.xml                              
   51 KiB │     +68 B │ 120.9 KiB │     +82 B │ ∆ META-INF/MANIFEST.MF                    
 54.5 KiB │     +54 B │ 120.9 KiB │     +82 B │ ∆ META-INF/CERT.SF                        
  1.1 KiB │     -11 B │     944 B │     -11 B │ ∆ assets/dexopt/baseline.profm            
  5.6 KiB │      -9 B │  28.7 KiB │     -40 B │ ∆ AndroidManifest.xml                     
    271 B │      -1 B │     120 B │       0 B │ ∆ META-INF/version-control-info.textproto 
    634 B │      -1 B │   1.2 KiB │       0 B │ ∆ res/a0.xml                              
    754 B │      -1 B │   1.7 KiB │       0 B │ ∆ res/cZ.xml                              
    948 B │      -1 B │   2.5 KiB │       0 B │ ∆ res/de.xml                              
    459 B │      -1 B │     824 B │       0 B │ ∆ res/e-.xml                              
    758 B │      +1 B │   1.4 KiB │       0 B │ ∆ res/fD.xml                              
    326 B │      +1 B │     464 B │       0 B │ ∆ res/wX.xml                              
  1.2 KiB │      -1 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────────┼───────────┼───────────┼───────────────────────────────────────────
  6.9 MiB │ +10.5 KiB │  12.3 MiB │ +19.1 KiB │ (total)
MANIFEST 
@@ -229,3 +229,2 @@
         android:autoRemoveFromRecents="true"
-        android:configChanges="0x3504"
         android:exported="false"
@@ -233,4 +232,3 @@
         android:name="com.stripe.android.link.LinkActivity"
-        android:theme="@style/StripeLinkBaseTheme"
-        android:windowSoftInputMode="0x16"
+        android:theme="@style/StripePaymentSheetDefaultTheme"
         />
DEX 
STRINGS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   45477 │ 45527 │ +50 (+109 -59) 
  
  + , bodyEmphasized=
  + , captionEmphasized=
  + , componentBackground=
  + , detailEmphasized=
  + , testTag=null, onClick=
  + , textPrimary=
  + , textSecondary=
  + A1
  + Add bank account in Link Native
  + An operation is not implemented: Not yet implemented
  + B1
  + C1
  + LB6/h0;
  + LB6/i0;
  + LB6/j0;
  + LB6/k0;
  + LB6/l0;
  + LB6/m0;
  + LB6/n0;
  + LJJJJI
  + LL6/i;
  + LLFJL
  + LM6/N;
  + LM6/O;
  + LN6/P;
  + LO6/b;
  + LO6/c;
  + LO6/d;
  + LO6/e;
  + LO6/f;
  + LO6/g;
  + LP6/e;
  + LT6/Q;
  + LT6/S;
  + La6/q;
  + Ld8/r;
  + Lg9/a2;
  + LinkColors(primary=
  + LinkTypography(title=
  + Lo8/z;
  + Lp9/B1;
  + Lq8/E;
  + Lw5/d;
  + Lx5/c;
  + MenuItem(title=
  + MenuPayload(title=
  + No Colors provided
  + No Shapes provided
  + No Typography provided
  + VJJJJJJJJJJJJJJJJJJJL
  + VLLLLLLLLLLLLLLLLII
  + VLLLLLLLLLLLLLLLLLI
  + VLLLLLLLLLLLLLLLLLII
  + VLLLLLLLLLLLLLLLLLLI
  + VLLZLZLZLLLLLL
  + [LB6/F;
  + [LB6/H;
  + [LB6/I;
  + [LB6/Z;
  + [LB6/o;
  + [LB6/q;
  + [LB6/s;
  + [LM6/I;
  + [LM6/M;
  + [LN6/L;
  + [LN6/O;
  + [LO6/f;
  + [LQ6/g;
  + [LV7/S0;
  + [La6/g;
  + [La6/i;
  + [Ld9/a;
  + [Lg9/E1;
  + [Lg9/H1;
  + [Lg9/O1;
  + [Lg9/U1;
  + [Lg9/X0;
  + [Lg9/Y1;
  + [Lg9/Z0;
  + [Lg9/a2;
  + [Lg9/c1;
  + [Lg9/f1;
  + [Lg9/m1;
  + [Lg9/r1;
  + [Lg9/u1;
  + [Lg9/z1;
  + [Lo8/l;
  + [Lq8/q;
  + [Lu8/X1;
  + [Lu8/d2;
  + [Lv7/o;
  + [Lv7/x;
  + [Lw8/E;
  + bottomSheetState
  + dismissSheet
  + dismissSheet()V
  + dismissalCoordinator
  + handleResult(Lcom/stripe/android/link/LinkActivityResult;)V
  + onAddBankAccount
  + onAddCard
  + onClose
  + s1
  + t1
  + u1
  + w1
  + x1
  + y1
  + z1
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"c3725b3","r8-mode":"full","version":"8.8.34"}
  
  - LC6/N;
  - LG5/H0;
  - LJ7/f0;
  - LJJJJJJJJI
  - LQ6/u;
  - LV7/T0;
  - Ld3/i;
  - Ld7/f;
  - Ld9/b;
  - LinkColors(componentBackground=
  - Lp8/I;
  - Lqa/t0;
  - Lu8/j2;
  - Lv7/D;
  - Lw8/U;
  - VJJJJJJJJJJLJJJJL
  - VLLLLLLLLLLLLLLII
  - VLLLLLLLLLLLLLLLLI
  - VLLZLZLZLLLLL
  - [LB6/A;
  - [LB6/B;
  - [LB6/V;
  - [LB6/k;
  - [LB6/l;
  - [LB6/m;
  - [LB6/z;
  - [LM6/G;
  - [LM6/K;
  - [LN6/I;
  - [LN6/M;
  - [LQ6/h;
  - [LV7/T0;
  - [La6/b;
  - [La6/h;
  - [Ld9/b;
  - [Lg9/D1;
  - [Lg9/G1;
  - [Lg9/N1;
  - [Lg9/T1;
  - [Lg9/W0;
  - [Lg9/X1;
  - [Lg9/Y0;
  - [Lg9/Z1;
  - [Lg9/b1;
  - [Lg9/e1;
  - [Lg9/l1;
  - [Lg9/p1;
  - [Lg9/t1;
  - [Lg9/x1;
  - [Lo8/i;
  - [Lq8/p;
  - [Lu8/a2;
  - [Lu8/e2;
  - [Lv7/p;
  - [Lv7/z;
  - [Lw8/F;
  - dismissWithResult(Lcom/stripe/android/link/LinkActivityResult;)V
  - onBack()V
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"dec764a","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   15955 │ 15971 │ +16 (+66 -50) 
  
  + LB6/h0;
  + LB6/i0;
  + LB6/j0;
  + LB6/k0;
  + LB6/l0;
  + LB6/m0;
  + LB6/n0;
  + LL6/i;
  + LM6/N;
  + LM6/O;
  + LN6/P;
  + LO6/b;
  + LO6/c;
  + LO6/d;
  + LO6/e;
  + LO6/f;
  + LO6/g;
  + LP6/e;
  + LT6/Q;
  + LT6/S;
  + La6/q;
  + Ld8/r;
  + Lg9/a2;
  + Lo8/z;
  + Lp9/B1;
  + Lq8/E;
  + Lw5/d;
  + Lx5/c;
  + [LB6/F;
  + [LB6/H;
  + [LB6/I;
  + [LB6/Z;
  + [LB6/o;
  + [LB6/q;
  + [LB6/s;
  + [LM6/I;
  + [LM6/M;
  + [LN6/L;
  + [LN6/O;
  + [LO6/f;
  + [LQ6/g;
  + [LV7/S0;
  + [La6/g;
  + [La6/i;
  + [Ld9/a;
  + [Lg9/E1;
  + [Lg9/H1;
  + [Lg9/O1;
  + [Lg9/U1;
  + [Lg9/X0;
  + [Lg9/Y1;
  + [Lg9/Z0;
  + [Lg9/a2;
  + [Lg9/c1;
  + [Lg9/f1;
  + [Lg9/m1;
  + [Lg9/r1;
  + [Lg9/u1;
  + [Lg9/z1;
  + [Lo8/l;
  + [Lq8/q;
  + [Lu8/X1;
  + [Lu8/d2;
  + [Lv7/o;
  + [Lv7/x;
  + [Lw8/E;
  
  - LC6/N;
  - LG5/H0;
  - LJ7/f0;
  - LQ6/u;
  - LV7/T0;
  - Ld3/i;
  - Ld7/f;
  - Ld9/b;
  - Lp8/I;
  - Lqa/t0;
  - Lu8/j2;
  - Lv7/D;
  - Lw8/U;
  - [LB6/A;
  - [LB6/B;
  - [LB6/V;
  - [LB6/k;
  - [LB6/l;
  - [LB6/m;
  - [LB6/z;
  - [LM6/G;
  - [LM6/K;
  - [LN6/I;
  - [LN6/M;
  - [LQ6/h;
  - [LV7/T0;
  - [La6/b;
  - [La6/h;
  - [Ld9/b;
  - [Lg9/D1;
  - [Lg9/G1;
  - [Lg9/N1;
  - [Lg9/T1;
  - [Lg9/W0;
  - [Lg9/X1;
  - [Lg9/Y0;
  - [Lg9/Z1;
  - [Lg9/b1;
  - [Lg9/e1;
  - [Lg9/l1;
  - [Lg9/p1;
  - [Lg9/t1;
  - [Lg9/x1;
  - [Lo8/i;
  - [Lq8/p;
  - [Lu8/a2;
  - [Lu8/e2;
  - [Lv7/p;
  - [Lv7/z;
  - [Lw8/F;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
  
...✂
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6308 │ 6310 │ +2 (+4 -2) 
  + drawable/stripe_ic_next_bank
  + drawable/stripe_ic_next_card
  + string/stripe_link_add_bank
  + string/stripe_link_add_debit_or_credit_card
  
  - drawable/stripe_link_bank_outlined
  - style/StripeLinkBaseTheme

@tillh-stripe tillh-stripe force-pushed the tillh/link-theme branch 5 times, most recently from 409dcff to 46fbbbe Compare May 6, 2025 17:30
Base automatically changed from tillh/link-theme to master May 6, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosmuvi-stripe @tillh-stripe