Skip to content

[LiPS] Verification dialog / full screen design adjustments #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

Summary

Motivation

https://jira.corp.stripe.com/browse/LINK_MOBILE-188

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented May 6, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │ +11 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │   0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │   0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │  +4 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │ +15 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20668 │ 20668 │ 0 (+1 -1) 
   types │  6493 │  6493 │ 0 (+0 -0) 
 classes │  5259 │  5259 │ 0 (+0 -0) 
 methods │ 31489 │ 31489 │ 0 (+0 -0) 
  fields │ 18222 │ 18222 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK
    compressed    │  uncompressed   │                                           
──────────┬───────┼──────────┬──────┤                                           
 size     │ diff  │ size     │ diff │ path                                      
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
  2.1 MiB │ +11 B │  4.3 MiB │  0 B │ ∆ classes.dex                             
    272 B │  +3 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.2 KiB │  -1 B │ 64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.9 KiB │  +1 B │ 64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
  2.1 MiB │ +15 B │  4.4 MiB │  0 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   20668 │ 20668 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1f6fa1a","r8-mode":"full","version":"8.8.34"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"066bdbf","r8-mode":"full","version":"8.8.34"}

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/LINK_MOBILE-188_android-tweak-verification-screen-design branch from eb0cf90 to 5fb8df2 Compare May 6, 2025 21:05
…INK_MOBILE-188_android-tweak-verification-screen-design

# Conflicts:
#	paymentsheet/src/main/java/com/stripe/android/link/ui/verification/VerificationDialog.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/verification/VerificationScreen.kt
…ILE-188_android-tweak-verification-screen-design

# Conflicts:
#	paymentsheet/res/drawable/stripe_link_add_green.xml
#	paymentsheet/src/main/java/com/stripe/android/link/theme/Color.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/ErrorText.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/LinkButton.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/LinkContent.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/LinkSpinner.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/PrimaryButton.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/SecondaryButton.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/menu/LinkMenu.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/signup/SignUpScreen.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/verification/VerificationDialog.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/verification/VerificationScreen.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/PaymentDetails.kt
#	paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/WalletScreen.kt
#	paymentsheet/src/test/java/com/stripe/android/link/ui/verification/VerificationScreenshotTest.kt
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.inline_LinkFieldsScreenshotTest_testErrorMessage[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.inline_LinkFieldsScreenshotTest_testErrorMessage[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.inline_LinkFieldsScreenshotTest_testErrorMessage[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.inline_LinkFieldsScreenshotTest_testErrorMessage[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.paymentmethod_PaymentMethodScreenScreenshotTest_form_with_button_disabled[].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.paymentmethod_PaymentMethodScreenScreenshotTest_form_with_button_enabled[].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.paymentmethod_PaymentMethodScreenScreenshotTest_form_with_error_message[].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingPrimaryFieldIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingPrimaryFieldIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingPrimaryFieldRequiresNameCollectionIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingPrimaryFieldRequiresNameCollectionIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsRequiresNameCollectionIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsRequiresNameCollectionIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsRequiresNameCollectionSubmittingErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsRequiresNameCollectionSubmitting][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsSubmittingErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenInputtingRemainingFieldsSubmitting][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingPrimaryFieldIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingPrimaryFieldIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingPrimaryFieldRequiresNameCollectionIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingPrimaryFieldRequiresNameCollectionIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsRequiresNameCollectionIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsRequiresNameCollectionIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsRequiresNameCollectionSubmittingErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsRequiresNameCollectionSubmitting][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsSubmittingErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledInputtingRemainingFieldsSubmitting][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledVerifyingEmailIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledVerifyingEmailIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledVerifyingEmailRequiresNameCollectionIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenSignUpEnabledVerifyingEmailRequiresNameCollectionIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenVerifyingEmailIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenVerifyingEmailIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenVerifyingEmailRequiresNameCollectionIdleErrorMessage][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.signup_SignUpScreenshotTest_testScreen[SignUpScreenVerifyingEmailRequiresNameCollectionIdle][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Canonical][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Canonical][LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Default][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Default][LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Error][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Error][LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Processing][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Processing][LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Unchanged][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.updatecard_UpdateCardScreenshotTest_testScreen[Unchanged][LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationDialogWithOTPFilledAndErrorMessage][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationDialogWithOTPFilled][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationDialogWithOTPNotFilled][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationScreenWithOTPFilledAndErrorMessage][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationScreenWithOTPFilledAndProcessing][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationScreenWithOTPFilledAndSendingNewCode][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationScreenWithOTPFilled][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.verification_VerificationScreenshotTest_testContent[VerificationScreenWithOTPNotFilled][].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountEnabled[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountEnabled[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountEnabled[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountEnabled[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountLiveModeEnabled[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountLiveModeEnabled[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountLiveModeEnabled[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testBankAccountLiveModeEnabled[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardDisabledAndSelected[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardDisabledAndSelected[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardDisabledAndSelected[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardDisabledAndSelected[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndSelected[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndSelected[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndSelected[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndSelected[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUnavailable[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUnavailable[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUnavailable[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUnavailable[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUpdating[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUpdating[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUpdating[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabledAndUpdating[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabled[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabled[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabled[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testCardEnabled[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testPassThroughEnabled[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testPassThroughEnabled[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testPassThroughEnabled[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_PaymentDetailsListItemScreenShotTest_testPassThroughEnabled[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccountAsDefault[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccountAsDefault[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccountAsDefault[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccountAsDefault[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccount[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccount[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccount[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testBankAccount[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCardAsDefault[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCardAsDefault[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCardAsDefault[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCardAsDefault[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCard[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCard[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCard[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testCard[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testPassthrough[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testPassthrough[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testPassthrough[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui.wallet_WalletPaymentMethodMenuScreenshotTest_testPassthrough[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarMenuScreenshotTest_testMenu[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarMenuScreenshotTest_testMenu[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarMenuScreenshotTest_testMenu[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarMenuScreenshotTest_testMenu[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarScreenshotTest_testLinkAppBarState[LinkAppBarNoHeaderWithOverflowMenuWithEmail][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarScreenshotTest_testLinkAppBarState[LinkAppBarNoHeaderWithOverflowMenuWithEmail][DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarScreenshotTest_testLinkAppBarState[LinkAppBarWithHeaderNoOverflowMenuWithEmail][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarScreenshotTest_testLinkAppBarState[LinkAppBarWithHeaderNoOverflowMenuWithEmail][DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarScreenshotTest_testLinkAppBarState[LinkAppBarWithHeaderWithOverflowMenuWithEmail][DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkAppBarScreenshotTest_testLinkAppBarState[LinkAppBarWithHeaderWithOverflowMenuWithEmail][DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkContentScreenshotTest_testLinkContentScreenHasOpaqueBackground[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_LinkContentScreenshotTest_testLinkContentScreenHasOpaqueBackground[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_PrimaryButtonScreenshotTest_testProcessingState[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_PrimaryButtonScreenshotTest_testProcessingState[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_PrimaryButtonScreenshotTest_testProcessingState[LightTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_PrimaryButtonScreenshotTest_testProcessingState[LightTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_SecondaryButtonScreenshotTest_testDisabledState[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_SecondaryButtonScreenshotTest_testDisabledState[DarkTheme,LargeFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_SecondaryButtonScreenshotTest_testEnabledState[DarkTheme,DefaultFont].png
#	paymentsheet/src/test/snapshots/images/com.stripe.android.link.ui_SecondaryButtonScreenshotTest_testEnabledState[DarkTheme,LargeFont].png
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/LINK_MOBILE-188_android-tweak-verification-screen-design branch from e23d583 to 0d76e30 Compare May 14, 2025 16:58
Comment on lines +181 to +185
modifier = Modifier
// - IconButton ensures a 48.dp touch target for accessibility targets.
// - The dialog padding is 24.dp.
// - The icon is 16.dp
.padding(12.dp)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small calculation to ensure we match design paddings keeping the button accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant