[POC] Add bank account on Link in MPE #10814

carlosmuvi-stripe · 2025-05-16T18:58:06Z

Summary

Motivation

Testing

Added tests
Modified tests
Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

…bank-account-link # Conflicts: # paymentsheet/src/main/java/com/stripe/android/link/LinkActivity.kt # paymentsheet/src/main/java/com/stripe/android/link/LinkActivityViewModel.kt # paymentsheet/src/main/java/com/stripe/android/link/LinkPaymentLauncher.kt # paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/WalletUiState.kt # paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/WalletViewModel.kt # paymentsheet/src/main/java/com/stripe/android/paymentelement/confirmation/link/LinkConfirmationDefinition.kt

github-actions · 2025-05-20T20:26:40Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed            
          ├───────────┬───────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff      
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
      dex │   4.3 MiB │   4.3 MiB │ +5.5 KiB │   9.6 MiB │   9.6 MiB │   +11 KiB 
     arsc │   2.5 MiB │   2.5 MiB │      0 B │   2.5 MiB │   2.5 MiB │       0 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  28.7 KiB │  28.7 KiB │       0 B 
      res │ 912.3 KiB │ 912.3 KiB │      0 B │   1.4 MiB │   1.4 MiB │       0 B 
   native │   3.5 MiB │   3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │ +1.5 KiB │   1.6 MiB │   1.6 MiB │  +1.5 KiB 
    other │ 197.2 KiB │ 197.2 KiB │     -9 B │ 372.4 KiB │ 372.4 KiB │       0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
    total │    13 MiB │    13 MiB │   +7 KiB │  23.9 MiB │    24 MiB │ +12.5 KiB 

         │         raw          │              unique               
         ├───────┬───────┬──────┼───────┬───────┬───────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff              
─────────┼───────┼───────┼──────┼───────┼───────┼───────────────────
   files │     2 │     2 │    0 │       │       │                   
 strings │ 46535 │ 46683 │ +148 │ 45568 │ 45584 │ +16 (+32 -16)     
   types │ 16476 │ 16564 │  +88 │ 15990 │ 16000 │ +10 (+23 -13)     
 classes │ 13502 │ 13512 │  +10 │ 13502 │ 13512 │ +10 (+14 -4)      
 methods │ 66601 │ 66736 │ +135 │ 66017 │ 66050 │ +33 (+1891 -1858) 
  fields │ 44136 │ 44213 │  +77 │ 43927 │ 43961 │ +34 (+1191 -1157) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6309 │ 6309 │  0

APK

     compressed      │     uncompressed      │                                           
──────────┬──────────┼───────────┬───────────┤                                           
 size     │ diff     │ size      │ diff      │ path                                      
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
   61 KiB │ +8.7 KiB │ 129.2 KiB │ +17.1 KiB │ ∆ classes2.dex                            
  4.3 MiB │ -3.1 KiB │   9.4 MiB │  -6.1 KiB │ ∆ classes.dex                             
  8.4 KiB │ +1.5 KiB │   8.3 KiB │  +1.5 KiB │ ∆ assets/dexopt/baseline.prof             
 54.5 KiB │     -6 B │ 120.9 KiB │       0 B │ ∆ META-INF/CERT.SF                        
    1 KiB │     -3 B │     936 B │      -3 B │ ∆ assets/dexopt/baseline.profm            
  1.2 KiB │     -3 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                       
    272 B │     +2 B │     120 B │       0 B │ ∆ META-INF/version-control-info.textproto 
   51 KiB │     -2 B │ 120.9 KiB │       0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
  4.5 MiB │   +7 KiB │   9.8 MiB │ +12.5 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   45568 │ 45584 │ +16 (+32 -16) 
  
  + , consumerPublishableKey=
  + , consumerSessionPublishableKey=
  + , financialConnectionsSheetConfiguration=
  + Failed to create Link account session
  + LB8/h;
  + LC6/N;
  + LC6/O;
  + LK6/A;
  + LK6/y;
  + LK6/z;
  + LLLLZLLLLLLLI
  + LU6/S;
  + LU6/T;
  + LU6/U;
  + LY6/D;
  + La6/q;
  + Lf6/q;
  + Lr7/j;
  + Lta/I;
  + VLLLLZZLLLZLLLLLLL
  + VLLLZLLLL
  + [LB5/t;
  + [LB5/x;
  + [Lf6/q;
  + [Lr7/c;
  + [Lr7/f;
  + [Lr7/j;
  + [Ls5/E;
  + [Ls5/I;
  + [Ls5/b1;
  + consumers/link_account_sessions
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"306ba84","r8-mode":"full","version":"8.8.34"}
  
  - LB5/W;
  - LLLLZLLLLLLI
  - LX7/e;
  - Lba/n;
  - Ls5/r1;
  - VLLLLZZLLLZLLLLLL
  - [LB5/w;
  - [LB5/y;
  - [Lf6/o;
  - [Lr7/b;
  - [Lr7/e;
  - [Lr7/i;
  - [Ls5/G;
  - [Ls5/J;
  - [Ls5/e1;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"200f5fc","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   15990 │ 16000 │ +10 (+23 -13) 
  
  + LB8/h;
  + LC6/N;
  + LC6/O;
  + LK6/A;
  + LK6/y;
  + LK6/z;
  + LU6/S;
  + LU6/T;
  + LU6/U;
  + LY6/D;
  + La6/q;
  + Lf6/q;
  + Lr7/j;
  + Lta/I;
  + [LB5/t;
  + [LB5/x;
  + [Lf6/q;
  + [Lr7/c;
  + [Lr7/f;
  + [Lr7/j;
  + [Ls5/E;
  + [Ls5/I;
  + [Ls5/b1;
  
  - LB5/W;
  - LX7/e;
  - Lba/n;
  - Ls5/r1;
  - [LB5/w;
  - [LB5/y;
  - [Lf6/o;
  - [Lr7/b;
  - [Lr7/e;
  - [Lr7/i;
  - [Ls5/G;
  - [Ls5/J;
  - [Ls5/e1;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   66017 │ 66050 │ +33 (+1891 -1858) 
  
  + A3.h t(long)
  + A3.h u(ArrayList, List)
  + A6.b <init>(E, e, p0, h)
  + A6.b <init>(h, h, h, b)
  + B3.e b(a, float) → float
  + B5.A <init>(String)
  + B5.B <init>(o, Q2, e)
  + B5.C <init>(m1, String, int)
  + B5.C h(Object) → Object
  + B5.D <init>(String, int)
  + B5.E <init>(i, int)
  + B5.F <init>(Object, int)
  + B5.F a() → Bundle
  + B5.G <init>(Throwable)
  + B5.G equals(Object) → boolean
  + B5.G hashCode() → int
  + B5.G toString() → String
  + B5.H <clinit>()
  + B5.J <init>(boolean)
  + B5.K <init>(V, y, Continuation)
  + B5.K g(Object, Object) → Object
  + B5.K m(Object, Continuation) → Continuation
  + B5.K p(Object) → Object
  + B5.L <init>(V, y, Continuation)
  + B5.M <init>(V, Intent, Continuation)
  + B5.N <init>(V, Continuation)
  + B5.O <init>(V, Continuation)
  + B5.P <init>(V, Continuation)
  + B5.Q <init>(V, y, Continuation)
  + B5.S <init>(V, ContinuationImpl)
  + B5.T <init>(V, i, Continuation)
  + B5.T g(Object, Object) → Object
  + B5.T m(Object, Continuation) → Continuation
  + B5.U <init>(V, d, Continuation)
  + B5.V <clinit>()
  + B5.V <init>(String, f0, B, d, C, c, h, b, a, l, x, v, O, y, v)
  + B5.V f(Object) → c
  + B5.V h(V, y, Uri)
  + B5.V i(V, ContinuationImpl) → Object
  + B5.V j(V, i, int)
  + B5.t <clinit>()
  + B5.t describeContents() → int
  + B5.t equals(Object) → boolean
  + B5.t hashCode() → int
  + B5.t toString() → String
  + B5.t writeToParcel(Parcel, int)
  + B5.u <init>(Z0)
  + B5.v <init>(Throwable)
  + B5.x <clinit>()
  + B5.x valueOf(String) → x
  + B5.x values() → x[]
  + B5.y <init>(d, boolean, m1, x, c)
  + B5.y a(y, boolean, m1, x, c, int) → y
  + B5.y equals(Object) → boolean
  + B5.y hashCode() → int
  + B5.y toString() → String
  + B5.z <init>(i)
  + B6.B <init>(a, O, G, F, d, E, b, f0, boolean, i)
  + B6.N <init>(c, LinkActivityContract, O)
  + B6.b0 <init>(E, String, String, boolean, b, String, String, I)
  + B6.j <init>(g, r, int)
  + B6.l <init>(E, String, boolean, b)
  + B8.b <init>(h, ContinuationImpl)
  + B8.c <init>(h, ContinuationImpl)
  + B8.d <init>(h, Continuation)
  + B8.e <init>(h, ContinuationImpl)
  + B8.f <init>(h, Continuation)
  + B8.g <init>(h, ContinuationImpl)
  + B8.g p(Object) → Object
  + B8.h <clinit>()
  + B8.h <init>(v, String)
  + B8.h a(String, String, String, F3, k, ContinuationImpl) → Object
  + B8.h b(String, P0, String, k, ContinuationImpl) → Object
  + B8.h c(String, z, String, k, ContinuationImpl) → Object
  + B8.h d(String, boolean, k, SuspendLambda) → Object
  + B8.h e(String, F0, String, String, String, k, String, ContinuationImpl) → Object
  + B8.h f(A2, k, Continuation) → Object
  + B8.h g(String, String, String, String, String, k, LinkedHashMap, ContinuationImp
...✂

carlosmuvi-stripe added 5 commits April 28, 2025 21:42

WIP

f5aed70

Removes unused args.

b69b7a7

Removes unused args.

27e0714

Removes unused args.

0c78fe4

carlosmuvi-stripe force-pushed the carlosmuvi/poc-add-bank-account-link branch from 2c36f60 to 0c78fe4 Compare May 20, 2025 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[POC] Add bank account on Link in MPE #10814

[POC] Add bank account on Link in MPE #10814

Uh oh!

carlosmuvi-stripe commented May 16, 2025

Uh oh!

github-actions bot commented May 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

[POC] Add bank account on Link in MPE #10814

Are you sure you want to change the base?

[POC] Add bank account on Link in MPE #10814

Uh oh!

Conversation

carlosmuvi-stripe commented May 16, 2025

Summary

Motivation

Testing

Screenshots

Changelog

Uh oh!

github-actions bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 20, 2025 •

edited

Loading