dark mode , bookmark selection un-readable

[monowovo]

Is your feature request related to a problem? Please describe.
version: SumatraPDF-prerel , 3.52, win11
abou the bookmark when dark mode as the picture shows:
if you move the mouse pointer in the bookmark area, the content you choose is blue dark, not easy to read.

Describe the solution you'd like
have to modify the color of the shadow.

[GitHubRulesOK]

That is a very old issue with all such altered inverse colourations but of course depends on the other settings so here we see the hover tootip is the best way to see poor choices of contrasted colour settings

[monowovo]

yes, it works. but I find only on the alphabets or letters. so if there is only one letter (dictionary), we must put the mouse point on it properly. would there be a little improvement, that the hover shows when the mouse point in the line not on the letter. Thanks anyway.

…

________________________________ 发件人: GitHubRulesOK ***@***.***> 发送时间: 2025年4月28日 4:05 收件人: sumatrapdfreader/sumatrapdf ***@***.***> 抄送: Monowovo ***@***.***>; Author ***@***.***> 主题: Re: [sumatrapdfreader/sumatrapdf] dark mode , bookmark selection un-readable (Issue #4908) [https://avatars.githubusercontent.com/u/12754913?s=20&v=4]GitHubRulesOK left a comment (sumatrapdfreader/sumatrapdf#4908)<#4908 (comment)> That is a very old issue with all such altered inverse colourations but of course depends on the other settings so here we see the hover tootip is the best way to see poor choices of contrasted colour settings image.png (view on web)<https://github.com/user-attachments/assets/4cee7499-c5c8-43d1-b03e-f99c561233dc> ― Reply to this email directly, view it on GitHub<#4908 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BRVVFWFEY6VWEHHTGBUHVXT23U2CPAVCNFSM6AAAAAB36M7K46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZTGYYTSNBVGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[GitHubRulesOK]

Agreed the hover in recent versions is limited to visible short text,
There was a past change in that behaviour when tree view was last changed and since I am not the developer to say why the new variation is more limited will simply leave this issue "open"

[ozone10]

Default light treeview explorer theme has really poor contrast. To fix it treeview would need to use dark explorer theme on Windows 10 and 11 or handle custom draw to have support for Vista and newer OS.

Here is dark explorer theme applied on both sidebars

[GitHubRulesOK]

@ozone10
I see your PR targets a couple of UI lines so that is helpful
but this thread was more about flipping selection highlight value to more opposed same as false theming is in effect only using the inverse command.

[ozone10]

@GitHubRulesOK
that was my point. Default explorer theme for treeview does not allow easy way to change color for selected item. You can change background and text color for "default" state but nothing else.

Using Windows 10 or 11 "dark" explorer theme will fix this issue, also make scrollbars dark and make collapse arrows have better contrast.

[MathisP75]

@ozone10 Oh yeah, this change is badly needed, I hope it gets merged.

[GitHubRulesOK]

@MathisP75
The merge will make no real difference, let me show you a collection of current issues and pull requests all in one screenshot.

Top left is where Acrobat Editor can change colours two different ways, on the left the red text on the mouse body can be set to blue by the inbuilt editor functions, which is not possible in other readers which can only alter colour "hinting" as shown top middle.

There are currently two problems with "theming" which is actually control of "hinting" so top right one complaint is controling the relative contrast between the cut off points where the "theming" is interfering with inversion as seen top right compared to lower right.

Another problem with inversion is at bottom left the Current Code page looks comparatively similar to top right but on inversion goes blindingly white with no visible content,

Thus we come to ALL the relevant PRs bottom right and the inversion is "brighter" (looks as if higher contrasts) and the mid bar is absorbed into the blackground but the text is still not visible! and scrollbars do not follow the canvas theming nor does the title bar (but that one alone is possibly my settings).

[MathisP75]

@GitHubRulesOK I don't know what you are talking about. I was talking about ozone10's fixes for scrollbar color, text color and separator color. Nothing to do with inverting the colors of the page.

[GitHubRulesOK]

@MathisP75
ALL The PRs are in the lower right so the division is not visible as it is black on black so it works but you cant see where it is.
However the scrollbar is still windows 10 and the text highlighted is black on black so no more visible than before.
These problems are not unique to SumatraPDF as here is same problems in latest Okular the menu bar is invisible on the topbar and the theming does not work with the UI controls in dark on dark (see top left) plus the scrollbar is windows 10!

[MathisP75]

What kind of messed up version of Okular do you have 😭 it doesn't look like this at all

[GitHubRulesOK]

@MathisP75
In light mode it looks perfect like this it is windows theming messes it up.

[GitHubRulesOK]

@MathisP75
Back to topic in hand on Windows 11 all those PR's
mean we have visible scrollbar with invisible division and still a Windows enforced Top bar and scroll bar but at least inversion is failing but bright. I also added in the suggestion of removing the white bottom border as per your other complaint. The core issue is windows has too many variables without a constant theming system that works in all compilers.

[ozone10]

I did not do PR for dark scrollbar and treeview style yet, it is in my custom build https://github.com/ozone10/sumatrapdf/tree/DarkMode