Skip to content

fix(es/codegen): Handle unicode escapes correctly #10423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

fix(es/codegen): Handle unicode escapes correctly #10423

wants to merge 11 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 30, 2025

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Apr 30, 2025
@kdy1 kdy1 self-assigned this Apr 30, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 684ce39

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10423 will degrade performances by 3.02%

Comparing kdy1/10353 (684ce39) with main (164cbaa)

Summary

❌ 2 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ serialization of serde 2.7 µs 2.7 µs -2.14%
❌ es/lints/libs/d3 27.9 ms 28.7 ms -3.02%

@kdy1
Copy link
Member Author

kdy1 commented May 2, 2025 

[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\u{591}'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '-'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'ۯ'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'ۺ'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '-'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\u{8ff}'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\u{200f}'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\\'
[crates/swc_ecma_codegen/src/lit.rs:461:33] &val_str = "d802"
[crates/swc_ecma_codegen/src/lit.rs:463:37] &v = 55298
[crates/swc_ecma_codegen/src/lit.rs:473:41] "push: \\" = "push: \\"
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'u'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'd'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '8'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '0'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '2'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '-'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\\'
[crates/swc_ecma_codegen/src/lit.rs:461:33] &val_str = "d803"
[crates/swc_ecma_codegen/src/lit.rs:463:37] &v = 55299
[crates/swc_ecma_codegen/src/lit.rs:473:41] "push: \\" = "push: \\"
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'u'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'd'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '8'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '0'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '3'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\\'
[crates/swc_ecma_codegen/src/lit.rs:461:33] &val_str = "d83a"
[crates/swc_ecma_codegen/src/lit.rs:463:37] &v = 55354
[crates/swc_ecma_codegen/src/lit.rs:473:41] "push: \\" = "push: \\"
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'u'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'd'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '8'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '3'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'a'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '-'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '\\'
[crates/swc_ecma_codegen/src/lit.rs:461:33] &val_str = "d83b"
[crates/swc_ecma_codegen/src/lit.rs:463:37] &v = 55355
[crates/swc_ecma_codegen/src/lit.rs:473:41] "push: \\" = "push: \\"
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'u'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'd'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '8'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '3'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'b'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'יִ'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '-'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '﷿'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'ﹰ'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = '-'
[crates/swc_ecma_codegen/src/lit.rs:389:9] c = 'ﻼ'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
Planned
Development

Successfully merging this pull request may close these issues.

SWC minifier un-escapes unicode characters
1 participant
@kdy1