Remove unused ligatures from tabler/icons-webfont #1312
Merged
+219
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
30 tasks
|
What's the status guys? |
|
I was waiting for review from maintainer. I did not noticed this PR has conflict with base now. I'll resolve in few days. |
…gature # Conflicts: # packages/icons-webfont/.build/build-webfont.mjs
|
Yea, those can be cleaned up by the repo owner or someone with direct write access. The improvement in performance is material. I'm so glad you were able to figure things out. Larry |
|
I merged upstream branch and no conflicts now |
|
works good, thank you for help! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove ligatures, this PR rewrites webfont generation to use svgicons2svgfont, svg2ttf, ttf2woff, wawoff2 npm packages instead of webfont.
Fixes #476
In addition, this updates packageManager field on package.json (to work my dev env works).
Fixes #1311
This PR removes
icon_namestyle ligatures from font. this will reduce size of font files a little. (2.36MB for all,Removing ligatures is possibly tiny breaking changes but as far as I tried, ligatures are not working before (tried with firefox) so I think no one would affected by this tiny breakage.