improvement(watch), enable triggering onComponentChange on another component #9301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new flag
--trigger <component-id>, when any change is happening, it runs theworkspace.onComponentChangefor the specified component-id.A real use case when this is needed is developing a vscode extension component. Because a vscode-extension must be bundled, its dependencies are always in the dist of the extension. As a result, when a dependency in the workspace is changed, the extension is not aware of it and not getting updated.
This flag is more like a workaround and not the best solution. Ideally, the flag would be "trigger-dependents" which would traverse the graph and trigger accordingly, but it's not worth it to implement as this point as it's an edge use-case.