Skip to content

refactor, move code from @teambit/legacy into existing or new components #9359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 72 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
5f5f9e0
refactor, move legacy e2e-helper to a new component teambit.legacy/e2…
davidfirst Jul 11, 2024
1a03eeb
remove duplicated ENV_POLICY
davidfirst Jul 11, 2024
8e3de44
move some fixtures
davidfirst Jul 11, 2024
bf81daf
add some more missing fixtures
davidfirst Jul 11, 2024
1415c8c
fix lint
davidfirst Jul 11, 2024
fef2864
fix conflicts
davidfirst Jul 12, 2024
e3b4cc7
update the env
davidfirst Jul 12, 2024
a6fd8d7
fix conflicts
davidfirst Jul 17, 2024
f16c2c9
refactor, move legacy src/remotes to a new component teambit.scope/re…
davidfirst Nov 22, 2024
133ea4b
Merge remote-tracking branch 'origin/master' into refactor-legacy-rem…
davidfirst Nov 22, 2024
9a9bcd3
refactor, move src/consumer/consumer-component into a new component t…
davidfirst Dec 4, 2024
58610ba
export the component and add as a package
davidfirst Dec 5, 2024
2c9829b
fix conflicts
davidfirst Dec 5, 2024
62f788a
move src/global-config/global-remotes.ts
davidfirst Dec 5, 2024
27eb4e1
refactor, move src/error into a new component teambit.legacy/cli/error
davidfirst Dec 5, 2024
10e2333
move src/scope/component-ops/auto-tag.ts to workspace aspect
davidfirst Dec 5, 2024
71e8c01
refactor, move snapDistance and getDivergeData into teambit.component…
davidfirst Dec 5, 2024
7ae7986
fix conflicts after merging from master
davidfirst Dec 5, 2024
ce590cd
refactor, move legacy scope/models and scope/objects into teambit.sco…
davidfirst Dec 6, 2024
7bebbf0
refactor, move src/scope/network to a new component teambit.scope/net…
davidfirst Dec 6, 2024
21e8fdc
move get-flattened-dependencies.ts and message-per-component.ts to sn…
davidfirst Dec 6, 2024
e4ed33f
move legacy scope/actions into teambit.scope/remote-actions
davidfirst Dec 6, 2024
0b334a9
move src/consumer/config to teambit.legacy/consumer-config and src/co…
davidfirst Dec 6, 2024
b911aff
move src/global-config/config.ts and src/api/consumer/lib/global-conf…
davidfirst Dec 6, 2024
6e2ccd1
move src/cli/* to cli aspect
davidfirst Dec 6, 2024
a56035f
move src/scope/component-ops/export-scope-components.ts to export aspect
davidfirst Dec 6, 2024
a4670a4
move legacy logger to teambit.legacy/logger
davidfirst Dec 6, 2024
1813c44
move legacy constants.ts to teambit.legacy/constants
davidfirst Dec 6, 2024
681b055
move src/scope/component-ops/traverse-versions.ts to teambit.componen…
davidfirst Dec 6, 2024
d570440
move src/scope into teambit.legacy/scope
davidfirst Dec 6, 2024
7246d87
fixing errors
davidfirst Dec 6, 2024
2a757f8
fixing errors
davidfirst Dec 6, 2024
5d3ed35
fixing errors
davidfirst Dec 6, 2024
7fb2940
fixing errors
davidfirst Dec 6, 2024
49e520f
fixing errors
davidfirst Dec 6, 2024
e9cb37e
fixing errors
davidfirst Dec 6, 2024
dbf1269
fixing errors
davidfirst Dec 6, 2024
d8849bf
fix conflicts
davidfirst Dec 6, 2024
3f74ddc
fix types
davidfirst Dec 6, 2024
18eb66e
fix conflicts
davidfirst Dec 6, 2024
e9213e3
fix build-types script
davidfirst Dec 6, 2024
d62ccbb
fix .bitmap issues
davidfirst Dec 6, 2024
7b96bf0
fix bit status
davidfirst Dec 6, 2024
7e41627
fix versions in .bitmap
davidfirst Dec 6, 2024
4b0cbd7
fix types
davidfirst Dec 6, 2024
f21c74e
revert pnpm-lock
davidfirst Dec 6, 2024
b3c6207
importing find-scope-path component
davidfirst Dec 6, 2024
43e6940
fix status
davidfirst Dec 6, 2024
acb6614
remove unit-test task in Circle, remove bluebird dep, started fixing …
davidfirst Dec 6, 2024
fb4fadd
fix some build errors
davidfirst Dec 6, 2024
152a24f
remove ramda
davidfirst Dec 6, 2024
b2eec22
Merge branch 'master' into refactor-remove-legacy-with-e2e
davidfirst Dec 6, 2024
7991665
fix lint
davidfirst Dec 7, 2024
02e1c4f
Merge branch 'refactor-remove-legacy-with-e2e' of https://github.com/…
davidfirst Dec 7, 2024
d072b92
fix tests
davidfirst Dec 7, 2024
877e6fe
add prop-types
GiladShoham Dec 8, 2024
408d116
move deps from package.json to workspace.jsonc
GiladShoham Dec 8, 2024
d3d869b
update lock file
GiladShoham Dec 8, 2024
3f8839c
add timer to package.json
GiladShoham Dec 8, 2024
4e63766
fix types
GiladShoham Dec 8, 2024
eba0fe6
fix
GiladShoham Dec 8, 2024
3ee1680
fix tests
davidfirst Dec 9, 2024
795d851
Merge remote-tracking branch 'origin/refactor-remove-legacy-with-e2e-…
davidfirst Dec 9, 2024
e8f8b84
remove packages from workspace.jsonc that exist already as components
davidfirst Dec 9, 2024
b3216a0
fix tests
davidfirst Dec 9, 2024
ea93399
fix e2e-tests
davidfirst Dec 9, 2024
aba84de
add missing fixture extension dir invalid-jest-config-env
davidfirst Dec 9, 2024
9645866
fix build and e2e-tests
davidfirst Dec 9, 2024
6b7db2a
avoid publishing @teambit/legacy anymore
davidfirst Dec 9, 2024
f4bc9e8
fix conflicts after merging from master
davidfirst Dec 9, 2024
a6afaec
fix a failing test temporarily
davidfirst Dec 9, 2024
48baceb
configure circle to have a larger resource for build/tag - from xlarg…
davidfirst Dec 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
220 changes: 199 additions & 21 deletions .bitmap
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,14 @@
"mainFile": "index.ts",
"rootDir": "scopes/toolbox/tables/cli-table"
},
"cli/error": {
"name": "cli/error",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/cli/error"
},
"cli/prompts": {
"name": "cli/prompts",
"scope": "teambit.legacy",
Expand Down Expand Up @@ -457,6 +465,55 @@
"mainFile": "index.ts",
"rootDir": "scopes/workspace/config-merger"
},
"constants": {
"name": "constants",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "constants.ts",
"rootDir": "components/legacy/constants",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"consumer": {
"name": "consumer",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/consumer",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"consumer-component": {
"name": "consumer-component",
"scope": "teambit.legacy",
"version": "0.0.1",
"mainFile": "index.ts",
"rootDir": "components/legacy/consumer-component"
},
"consumer-config": {
"name": "consumer-config",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/consumer-config",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"content/cli-reference": {
"name": "content/cli-reference",
"scope": "teambit.harmony",
Expand Down Expand Up @@ -534,6 +591,20 @@
"mainFile": "index.ts",
"rootDir": "scopes/harmony/doctor"
},
"e2e-helper": {
"name": "e2e-helper",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/e2e-helper",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"eject": {
"name": "eject",
"scope": "teambit.workspace",
Expand Down Expand Up @@ -702,13 +773,6 @@
"mainFile": "index.ts",
"rootDir": "scopes/git/git"
},
"global-config": {
"name": "global-config",
"scope": "teambit.harmony",
"version": "0.0.1067",
"mainFile": "index.ts",
"rootDir": "scopes/harmony/global-config"
},
"graph": {
"name": "graph",
"scope": "teambit.component",
Expand Down Expand Up @@ -891,13 +955,6 @@
"mainFile": "index.ts",
"rootDir": "components/legacy/loader"
},
"logger": {
"name": "logger",
"scope": "teambit.harmony",
"version": "0.0.1157",
"mainFile": "index.ts",
"rootDir": "scopes/harmony/logger"
},
"mdx": {
"name": "mdx",
"scope": "teambit.mdx",
Expand Down Expand Up @@ -1045,6 +1102,13 @@
"mainFile": "index.ts",
"rootDir": "scopes/html/modules/fetch-html-from-url"
},
"modules/find-scope-path": {
"name": "modules/find-scope-path",
"scope": "teambit.scope",
"version": "0.0.1",
"mainFile": "index.ts",
"rootDir": "components/modules/find-scope-path"
},
"modules/fs-cache": {
"name": "modules/fs-cache",
"scope": "teambit.workspace",
Expand Down Expand Up @@ -1213,6 +1277,20 @@
"mainFile": "index.ts",
"rootDir": "scopes/defender/multi-tester"
},
"network": {
"name": "network",
"scope": "",
"version": "",
"defaultScope": "teambit.scope",
"mainFile": "index.ts",
"rootDir": "scopes/scope/network",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"network/get-port": {
"name": "network/get-port",
"scope": "teambit.toolbox",
Expand Down Expand Up @@ -1241,6 +1319,20 @@
"mainFile": "index.ts",
"rootDir": "scopes/ui-foundation/notifications/aspect"
},
"objects": {
"name": "objects",
"scope": "",
"version": "",
"defaultScope": "teambit.scope",
"mainFile": "index.ts",
"rootDir": "scopes/scope/objects",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"overview/api-reference-table-of-contents": {
"name": "overview/api-reference-table-of-contents",
"scope": "teambit.api-reference",
Expand Down Expand Up @@ -1395,6 +1487,22 @@
"mainFile": "index.ts",
"rootDir": "scopes/component/refactoring"
},
"remote-actions": {
"name": "remote-actions",
"scope": "",
"version": "",
"defaultScope": "teambit.scope",
"mainFile": "index.ts",
"rootDir": "scopes/scope/remote-actions"
},
"remotes": {
"name": "remotes",
"scope": "",
"version": "",
"defaultScope": "teambit.scope",
"mainFile": "index.ts",
"rootDir": "components/scope/remotes"
},
"remove": {
"name": "remove",
"scope": "teambit.component",
Expand Down Expand Up @@ -1563,13 +1671,6 @@
"mainFile": "index.ts",
"rootDir": "scopes/semantics/schema"
},
"scope": {
"name": "scope",
"scope": "teambit.scope",
"version": "1.0.487",
"mainFile": "index.ts",
"rootDir": "scopes/scope/scope"
},
"scope-api": {
"name": "scope-api",
"scope": "teambit.legacy",
Expand Down Expand Up @@ -1605,6 +1706,20 @@
"mainFile": "index.ts",
"rootDir": "scopes/scope/sign"
},
"snap-distance": {
"name": "snap-distance",
"scope": "",
"version": "",
"defaultScope": "teambit.component",
"mainFile": "index.ts",
"rootDir": "scopes/component/snap-distance",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"snapping": {
"name": "snapping",
"scope": "teambit.component",
Expand Down Expand Up @@ -1682,6 +1797,69 @@
"mainFile": "index.ts",
"rootDir": "scopes/api-reference/tagged-exports"
},
"teambit.harmony/global-config": {
"name": "global-config",
"scope": "teambit.harmony",
"version": "0.0.1067",
"mainFile": "index.ts",
"rootDir": "scopes/harmony/global-config"
},
"teambit.harmony/logger": {
"name": "logger",
"scope": "teambit.harmony",
"version": "0.0.1157",
"mainFile": "index.ts",
"rootDir": "scopes/harmony/logger"
},
"teambit.legacy/global-config": {
"name": "global-config",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/global-config",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"teambit.legacy/logger": {
"name": "logger",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/logger",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"teambit.legacy/scope": {
"name": "scope",
"scope": "",
"version": "",
"defaultScope": "teambit.legacy",
"mainFile": "index.ts",
"rootDir": "components/legacy/scope",
"config": {
"teambit.node/envs/[email protected]": {},
"teambit.envs/envs": {
"env": "teambit.node/envs/node-babel-mocha"
}
}
},
"teambit.scope/scope": {
"name": "scope",
"scope": "teambit.scope",
"version": "1.0.487",
"mainFile": "index.ts",
"rootDir": "scopes/scope/scope"
},
"tester": {
"name": "tester",
"scope": "teambit.defender",
Expand Down
35 changes: 6 additions & 29 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -382,26 +382,6 @@ jobs:
name: 'notify community slack'
command: 'cd bit && node ./scripts/slack-deploy-notification.js community'

unit_test:
<<: *defaults
steps:
- run:
name: 'save SHA to a file'
command: 'echo $CIRCLE_SHA1 > .circle-sha'
- attach_workspace:
at: ./
- run: 'cd bit && mkdir junit'
- run:
name: 'Run unit tests'
command: 'cd bit && npm run test-circle'
environment:
FORCE_COLOR: 1
MOCHA_FILE: junit/unit-test-results.xml
when: always
- store_test_results:
path: bit/junit
- store_artifacts:
path: bit/junit

lint:
<<: *defaults
Expand Down Expand Up @@ -519,11 +499,11 @@ jobs:
path: bit/yarn.lock

bit_build:
resource_class: xlarge
resource_class: 2xlarge
<<: *defaults
environment:
BIT_FEATURES: cloud-importer-v2
NODE_OPTIONS: --max-old-space-size=15000
NODE_OPTIONS: --max-old-space-size=30000
steps:
- attach_workspace:
at: ./
Expand Down Expand Up @@ -555,16 +535,16 @@ jobs:
name: 'bit build'
command: 'cd bit && bit build'
environment:
NODE_OPTIONS: --max-old-space-size=15000
NODE_OPTIONS: --max-old-space-size=30000
- store_artifacts:
path: ~/Library/Caches/Bit/logs

bit_tag:
resource_class: xlarge
resource_class: 2xlarge
<<: *defaults
environment:
BIT_FEATURES: cloud-importer-v2
NODE_OPTIONS: --max-old-space-size=15000
NODE_OPTIONS: --max-old-space-size=30 000
steps:
- attach_workspace:
at: ./
Expand All @@ -586,7 +566,7 @@ jobs:
- run:
name: setting npmjs registry with publishing permission
command: echo "//registry.npmjs.org/:_authToken=${npmjsRegistryToken}" >> ~/.npmrc
- run: cd bit && node scripts/bump-bit-legacy-ver.js
# - run: cd bit && node scripts/bump-bit-legacy-ver.js
- run: bvm link
- run: cd bit && bit config set force_local_build true
# temporary, check if we can remove it
Expand Down Expand Up @@ -1249,9 +1229,6 @@ workflows:
requires:
- set_npm_registries
- checkout_code
- unit_test:
requires:
- setup_harmony
- lint:
requires:
- setup_harmony
Expand Down
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
node_modules
e2e/fixtures
components/legacy/e2e-helper/fixtures
scopes/semantics/schema/mock

# A temp file should be required from outside (via npm) so no point to fix it
Expand Down
Loading