exchanges: Update exchange templates #1777
Conversation
… into template_update
|
… into template_update
… into template_update
… into template_update
… into template_update
… into template_update
… into template_update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
+ Coverage 39.25% 39.38% +0.13%
==========================================
Files 426 427 +1
Lines 176193 175228 -965
==========================================
- Hits 69158 69018 -140
+ Misses 99454 98688 -766
+ Partials 7581 7522 -59
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks for updating this! Will get @cranktakular to add on to this as well given his two most recent exchange implementations
| WebsocketCapabilities: protocol.Features{ | ||
| TickerFetching: true, | ||
| OrderbookFetching: true, | ||
| TickerFetching: true, |
There was a problem hiding this comment.
These two true assignments need indenting fixes
| @@ -303,6 +303,20 @@ go run documentation.go | |||
|
|
|||
| This will generate a readme file for the exchange which can be found in the new exchange's folder | |||
There was a problem hiding this comment.
One request for this file would be to remove a lot of the FTX code suggestions which are no longer relevant and could just provide general statements whilst also referring to existing implementations as a reference point
shazbert
added
review me
| // UpdateOrderExecutionLimits updates order execution limits | ||
| func ({{.Variable}} *{{.CapitalName}}) UpdateOrderExecutionLimits(_ context.Context, _ asset.Item) error { | ||
| return common.ErrNotYetImplemented | ||
| } | ||
|
|
||
| // SetLeverage sets the account's initial leverage for the asset type and pair | ||
| func ({{.Variable}} *{{.CapitalName}}) SetLeverage(_ context.Context, _ asset.Item, _ currency.Pair, _ margin.Type, _ float64, _ order.Side) error { |
There was a problem hiding this comment.
Can you please do a check for these wrapper functions whether they are exchange.Base methods. We can remove them as methods and these will need to be forcefully applied to all exchanges for standardisation.
Selam(🕊️) be with you, team!
This PR includes minor updates to the exchange templates used for instantiating new exchanges.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as the item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also, consider improving test coverage whilst working on a certain feature or package.
Checklist