Skip to content

Reassign linking commands to resume/halt/suspend (nondestructive vagrant commands) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patcon opened this issue Jul 12, 2013 · 3 comments

Comments

@patcon
Copy link

patcon commented Jul 12, 2013

Love this plugin, for the record!

My suggestion is that it might be inconsistent to have up and destroy be the commands that link and unlink the servers, since these are essentially "bang-like" commands (up! and destroy!). I would suggest that these command should be no-ops, and resume and halt/suspend should be the linking commands.

To explain, I'm working on a tool that would allow teams to manage their own infra for each project. The tool will use the aws provider when credentials are available (ie the ops person is spinning up the server), but the managed-servers provider when credentials are unavailable. The current commands seem non-ideal, as the existence of credentials can turn non-destructive commands into destructive ones.

Yes, I could rethink how my tool works, but it doesn't detract from the fact that the use of up and destroy are currently probably inappropriately repurposed (despite the fact that they're the ones we're most accustomed to using with vagrant :)

Thoughts? It's probably a major version bump, as I know it would be a big change. I could turn this issue into a PR if you think it has merit!

@tknerr
Copy link
Owner

tknerr commented Jul 13, 2013

Would separate link and unlink commands be helpful for you?

I'd prefer that over using resume / halt for this. Once there are separate
link/unlink commands we can make up/destroy no-ops or just logging.

Yes, PRs are welcome! :-)
On Jul 12, 2013 6:24 PM, "Patrick Connolly" [email protected]
wrote:

Love this plugin, by the way!

My suggestion is that it might be inconsistent to have up and destroy be
the commands that link and unlink the servers, since these are essentially
"bang-like" commands (up! and destroy!). I would suggest that these
command should be no-ops, and resume and halt/suspend should be the
linking commands.

To explain, I'm working on a tool that would allow teams to manage their
own infra for each project. The tool will use the aws provider when
credentials are available (ie the ops person is spinning up the server),
but the managed-servers provider when credentials are unavailable. The
current commands seem non-ideal, as the existence of credentials can turn
non-destructive commands into destructive ones.

Yes, I could rethink how my tool works, but it doesn't detract from the
fact that the use of up and destroy are currently probably unintuitively
applied :)

Thoughts? It's probably a major version bump, as I know it would be a big
change. I could turn this issue into a PR if you think it has merit!


Reply to this email directly or view it on GitHubhttps://github.com//issues/8
.

@tknerr
Copy link
Owner

tknerr commented Jul 13, 2013

This is basically #3 without the aliasing

@patcon
Copy link
Author

patcon commented Jul 13, 2013

Awesome! Yeah, I really feel that no-ops are much more conservation for up/destroy. I'll work at a PR as soon as I can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants