-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(client-config): set isLoaded
to false on API status update
#12371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the isLoaded
flag in the client configuration loading logic, introducing a potential bug where successful data fetches incorrectly set isLoaded
to false
.
- In
/packages/twenty-front/src/modules/client-config/hooks/useClientConfig.ts
, theisLoaded
flag is incorrectly set tofalse
after successful data fetch, which could trigger infinite loading loops - The
ClientConfigProviderEffect
component relies onisLoaded
to determine when to fetch data, making this change particularly problematic - This change contradicts the logic in
ClientConfigProvider
which uses this state to handle error displays
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/client-config/hooks/useClientConfig.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/client-config/hooks/useClientConfig.ts
Show resolved
Hide resolved
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:20509 This environment will automatically shut down when the PR is closed or after 5 hours. |
Hey @AMoreaux thanks
|
Attempt at #12289 (edit Félix: removed fix keyword since I don't think it fixes it)