Appv2 faucet #4189
Draft
Appv2 faucet #4189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Caglankaan
had a problem deploying
to
app2-preview
GitHub Actions
Failure
Caglankaan
had a problem deploying
to
app2-preview
GitHub Actions
Failure
Caglankaan
had a problem deploying
to
app2-preview
GitHub Actions
Failure
App 2 🤌✨ Deployment complete! Take a peek over at https://b63ffa4f.app2-9yo.pages.dev |
cor
requested changes
Apr 8, 2025
| Idle: {} | ||
| Verifying: {} | ||
| Verified: { token: string } | ||
| Submitting: { token: string } |
There was a problem hiding this comment.
Specify what the type of schema is of token by using one of the types from schema/
| type FaucetProcessState = Data.TaggedEnum<{ | ||
| Idle: {} | ||
| Verifying: {} | ||
| Verified: { token: string } |
Comment on lines
+57
to
+61
| const handleTurnstileError = (e: CustomEvent<{ code: string }>) => { | ||
| faucetProcess.set(FaucetProcess.Failure({ error: `Verification error: ${e.detail.code}` })) | ||
| showTurnstile = false | ||
| } |
There was a problem hiding this comment.
we only get a code and no other data? best to always propagate all error data all the way upwards, so that we get full context in the app if there is any error
There was a problem hiding this comment.
https://github.com/ghostdevv/svelte-turnstile?tab=readme-ov-file#events
according to this page we only get code on error scenerio
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Signed-off-by: Kaan Caglan <[email protected]>
Caglankaan
force-pushed
the
appv2-faucet
branch
from
9fc913c to
6feb433
Compare
Caglankaan
had a problem deploying
to
app2-preview
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.