thirdparty.zstd: upgrade to 1.5.8

[kbkpbot]

require by issue #24595

[huly-for-github]

Connected to Huly®: V_0.6-22960

[jorgeluismireles]

I think your title has a typo 1.5.8 as the version is 1.5.7

[kbkpbot]

I think your title has a typo 1.5.8 as the version is 1.5.7

This is from github current code :

/*------   Version   ------*/
#define ZSTD_VERSION_MAJOR    1
#define ZSTD_VERSION_MINOR    5
#define ZSTD_VERSION_RELEASE  8
#define ZSTD_VERSION_NUMBER  (ZSTD_VERSION_MAJOR *100*100 + ZSTD_VERSION_MINOR *100 + ZSTD_VERSION_RELEASE)

[spytheman]

Excellent work.

[lcheylus]

@kbkpbot Thanks for your work.

But why do you use current zstd sources from GH instead of the latest official release (version 1.5.7) as requested in my issue ? => https://github.com/facebook/zstd/releases/tag/v1.5.7

With your commit/upgrade, we don't know the commit used to generate "amalgamate" zstd.c file.

For thirdparty, it's better to use release/tag for update => simpler to follow and with current sources from GH, there may be regressions and bugs.

[kbkpbot]

@kbkpbot Thanks for your work.

But why do you use current zstd sources from GH instead of the latest official release (version 1.5.7) as requested in my issue ? => https://github.com/facebook/zstd/releases/tag/v1.5.7

With your commit/upgrade, we don't know the commit used to generate "amalgamate" zstd.c file.

For thirdparty, it's better to use release/tag for update => simpler to follow and with current sources from GH, there may be regressions and bugs.

I agree with you, and I will submit a new PR for v1.5.7.
BTW, maintain a third party lib in v is not easy, and we should find out some method/tools make it become easier.
I suggest we only modify the configuration, not the code in them. As we find some bugs in them, it is better to submit issues in upstream. Frequently back-port just make things worse.