issue 8649: host_pods should not be mandatory to node-agent #8774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't be alarmed about e2e tests.. unrelated to PR #8766 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8774 +/- ##
=======================================
Coverage 59.53% 59.54%
=======================================
Files 371 371
Lines 40196 40239 +43
=======================================
+ Hits 23932 23959 +27
- Misses 14767 14780 +13
- Partials 1497 1500 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lyndon-Li
reviewed
Mar 11, 2025
mpryc
force-pushed
the
upstream_8649
branch
3 times, most recently
from
8d92ebd to
8579586
Compare
Lyndon-Li
reviewed
Mar 11, 2025
Enables the node-agent to start even if the /host_pods path does not exist. If the path is present, the existing logic remains unchanged, ensuring it is readable. Signed-off-by: Michal Pryc <[email protected]>
|
Squashed the 3 changes to make downstream cherry-pick clean. |
shubham-pampattiwar
approved these changes
Mar 11, 2025
kaovilai
approved these changes
Mar 11, 2025
Lyndon-Li
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8649. The host_pods path should not be mandatory for node-agent.
This update enables the node-agent to start even if the /host_pods path does not exist. If the path is present, the existing logic remains unchanged, ensuring it is readable.
This PR does not address mounting (or omitting) the /host_pods directory.
Additionally, this change specifically resolves #8649 and not #8185, which requires further design work and will be handled in a separate PR.