Skip to content

Call WaitGroup.Done() once only when PVB changes to fianl status the first time to avoid panic #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

ywk253100
Copy link
Contributor

Call WaitGroup.Done() once only when PVB changes to fianl status the first time to avoid panic

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.56%. Comparing base (4bd86f1) to head (f64fb36).
Report is 2 commits behind head on release-1.16.

Files with missing lines Patch % Lines
pkg/podvolume/backupper.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.16    #8940   +/-   ##
=============================================
  Coverage         59.56%   59.56%           
=============================================
  Files               370      370           
  Lines             40251    40262   +11     
=============================================
+ Hits              23975    23983    +8     
- Misses            14775    14777    +2     
- Partials           1501     1502    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywk253100 ywk253100 added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 14, 2025
@ywk253100 ywk253100 requested a review from Lyndon-Li May 14, 2025 07:32
…first time to avoid panic

Call WaitGroup.Done() once only when PVB changes to final status the first time to avoid
panic

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@ywk253100 ywk253100 merged commit 2eb97fa into vmware-tanzu:release-1.16 May 14, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants