Skip to content

feat(rspack): implement addEntry, succeedEntry & failedEntry hooks #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(rspack): implement addEntry, succeedEntry & failedEntry hooks #10470

wants to merge 1 commit into from

Conversation

re-taro
Copy link
Contributor

@re-taro re-taro commented May 25, 2025

Summary

Adds the missing compiler.hooks.addEntry, compiler.hooks.succeedEntry, and compiler.hooks.failedEntry to rspack.

  • Why: Several webpack-ecosystem plugins—most notably ProgressPlugin—depend on these hooks to report build progress and entry-point status. Their absence broke progress output and blocked plugin compatibility.
  • Problem solved: Restores correct progress reporting and lets existing webpack plugins work in rspack without modification, advancing API parity.

close #3523
close #3524
close #3525

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented May 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 27398f2
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/683346d8b3e0b4000840fb3f

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler.hooks.failedEntry hook missing compiler.hooks.addEntry hook missing compiler.hooks.succeedEntry hook missing
1 participant
@re-taro