Skip to content

feat(rstest_plugin): handle import.meta.dirname and import.meta.filename #10489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

feat(rstest_plugin): handle import.meta.dirname and import.meta.filename #10489

merged 1 commit into from
May 28, 2025

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented May 27, 2025 •
edited
Loading

Summary

Handle import.meta.dirname and import.meta.filename just like __dirname and __filename in Rstest plugin.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented May 27, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2276efb
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6836b6a472e6a10008c7980e

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels May 27, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10489 will not alter performance

Comparing rstest-plugin2 (2276efb) with main (792ad27)

Summary

✅ 11 untouched benchmarks

@fi3ework fi3ework force-pushed the rstest-plugin2 branch 2 times, most recently from 847e9cb to f143eee Compare May 28, 2025 05:14
@fi3ework fi3ework requested a review from LingyuCoder May 28, 2025 07:30
@fi3ework fi3ework marked this pull request as ready for review May 28, 2025 07:30
@fi3ework fi3ework merged commit a310bc8 into main May 28, 2025
35 checks passed
@fi3ework fi3ework deleted the rstest-plugin2 branch May 28, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fi3ework @LingyuCoder