Skip to content

feat(core): passes controller.signal into the new Request #13747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jp-knj
Copy link
Contributor

@jp-knj jp-knj commented May 4, 2025

Changes

  • What does this change?
    Issue Astro request.signal abort event not called for SSE #12867 demonstrated that SSE streams never fire request.signal on disconnect, so user‐land cleanup (e.g. closing streams, deleting clients) never runs. By wiring up the real HTTP socket’s close event to the AbortSignal, we restore expected semantics:

  • Before/after screenshots can help as well.

  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

Copy link

changeset-bot bot commented May 4, 2025

⚠️ No Changeset found

Latest commit: 6139c30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 4, 2025
Copy link

codspeed-hq bot commented May 4, 2025

CodSpeed Performance Report

Merging #13747 will not alter performance

Comparing jp-knj:add-signal (6139c30) with main (6935540)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant