feat(core): passes controller.signal
into the new Request
#13747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this change?
Issue Astro request.signal abort event not called for SSE #12867 demonstrated that SSE streams never fire
request.signal
on disconnect, so user‐land cleanup (e.g. closing streams, deleting clients) never runs. By wiring up the real HTTP socket’s close event to theAbortSignal
, we restore expected semantics:Before/after screenshots can help as well.
Don't forget a changeset!
pnpm exec changeset
Testing
Docs