Skip to content

Fix(Type): Add loading behavior option to ImageSharedProps type #13835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asaura08
Copy link

Changes

The property 'loading' does not exist on type 'IntrinsicAttributes & Props'. ts(2322)t`

Testing

  • No specific tests were added
  • Tested on local repo and with pnpm run test

Docs

No documentation required

Copy link

changeset-bot bot commented May 21, 2025

🦋 Changeset detected

Latest commit: cc2c16e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 21, 2025
Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Performance Report

Merging #13835 will not alter performance

Comparing asaura08:main (cc2c16e) with main (dfd4ace)

Summary

✅ 6 untouched benchmarks

@florian-lefebvre
Copy link
Member

Loading prop type should work already, can you first open an issue so we know what we are fixing? Thanks!

@florian-lefebvre florian-lefebvre added the needs response Issue needs response from OP label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs response Issue needs response from OP pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants