type(list): If loadingText is set to null, hidden the loading comp #13440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13440 +/- ##
==========================================
+ Coverage 89.60% 89.67% +0.07%
==========================================
Files 257 257
Lines 7013 7034 +21
Branches 1736 1742 +6
==========================================
+ Hits 6284 6308 +24
+ Misses 384 383 -1
+ Partials 345 343 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chenjiahan
reviewed
Apr 20, 2025
packages/vant/src/list/List.tsx
Outdated
| if (slots.loading) { | ||
| return <div class={bem('loading')}>{slots.loading()}</div>; | ||
| } | ||
| const text = props.loadingText ?? t('loading'); |
There was a problem hiding this comment.
建议允许传入 null，并在值为 null 的时候不展示 loading，这样可以避免 break 现有的项目
There was a problem hiding this comment.
参考
vant/packages/vant/src/checkbox/Checker.tsx
Lines 48 to 52 in e343c7a
There was a problem hiding this comment.
我之所以这样写，是因为finished-text=""能达到不显示加载完毕的提示，想着他们俩应该尽量统一，避免认知错乱。
所以，仍然按上面要求的改吗？佬。
There was a problem hiding this comment.
抱歉回复晚了，我还是倾向于尽可能不破坏现有的行为，所以新增一个 null 是比较合适的选择
yoyo837
force-pushed
the
allow-loadingtext-empty
branch
from
094f197 to
fbbc7fd
Compare
yoyo837
changed the title
yoyo837
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
允许
loadingText设置为null, 不显示loading效果