-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Add "pt" locale for newsletter #23278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the Portuguese translation file for newsletters by populating all previously empty translation strings with their appropriate Portuguese equivalents. No new keys were introduced or removed; the update solely fills in the existing keys with localized Portuguese text for various newsletter and membership-related messages. Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
ghost/i18n/locales/pt/newsletter.json (7)
4-4
: Update translation for "By {authors}".
The preposition “by” in this context is more naturally rendered as “Por {authors}” rather than “De {authors}”.
6-6
: Incorrect translation of "complimentary".
Here “complimentary” means “cortesia” or “grátis”, not “complementar”. Consider using"cortesia"
or"grátis"
to convey the intended meaning.
10-10
: Adjust translation of "Less like this".
The UI action “Less like this” is not “I didn’t like it” but a filtering command. A better translation would be"Menos assim"
or"Mostrar menos como este"
.
17-17
: Refine translation of "trialing".
The English key “trialing” refers to an active trial period. For clarity, consider"em período de teste"
or"em avaliação"
.
19-20
: Consistent translation for "Upgrade" action.
- The key
"Upgrade"
is currently"Fazer upgrade"
, retaining the English term; consider"Atualizar"
or"Atualização"
.- For
"Upgrade to continue reading."
, the translation is missing a trailing period—please add.
to match the source punctuation.
21-21
: Translate "browser" to Portuguese.
The translation"Ver no browser"
preserves the English word “browser”. For full localization, use"Ver no navegador"
.
22-22
: Fix typo in email term.
The text uses"e-email"
but the correct Portuguese term is"e-mail"
. Please update accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/pt/newsletter.json
(1 hunks)
🔇 Additional comments (2)
ghost/i18n/locales/pt/newsletter.json (2)
3-6
: Placeholders and HTML tags preserved correctly.
The translations maintain the variable placeholders ({site}
,{authors}
,{date}
) and HTML<strong>
tags exactly as in the source, ensuring template integrity.Also applies to: 22-27
6-9
: General translations look accurate.
Static phrases such as "Comentar", "E-mail", "grátis", "Continuar a ler", "Gerir subscrição", "Membro desde", "Gostei", "Nome", "pago", "Detalhes da subscrição", and "Cancelar subscrição" correctly reflect their English originals.Also applies to: 11-16, 18-19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Your commit message about AI overloads has me laughing.
Because I do not speak Portuguese, I've used AI tools to review your contribution and left a few notes on it. As the EXPERT HUMAN, you are welcome and encouraged to overrule the AI at any point, but please do take look, because sometimes the AI does catch an error.
Please request a re-review or leave a comment and @ me when ready for me to look at it again. Thanks!
"Name": "Nome", | ||
"paid": "pago", | ||
"Subscription details": "Detalhes da subscrição", | ||
"trialing": "em període de avaliação", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be período ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
"Upgrade": "Fazer upgrade", | ||
"Upgrade to continue reading.": "Faça upgrade para continuar a ler.", | ||
"View in browser": "Ver no navegador", | ||
"You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Está a receber este e-mail porque é <strong>subscritor/a %%{status}%%</strong> de {site}.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'status' variable will be substituted with the strings for free, paid, complimentary, and trialing. Could you please review these for grammar? This is an area that has been troublesome for many translators. AI suggests 'com oferta' instead of 'oferta'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the phrasing. It's more verbose, but I think clearer and a but more natural.
Just European Portuguese translations :)